chore: update husky package for web #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @orvn! Sorry I've totally neglected this PR till now 🤦♂️ Do you think this is safe to merge? |
joshJarr
commented
Jun 17, 2022
| getTokens() | ||
| }, []); | ||
| getTokens(); | ||
| }, [getTokens]); |
There was a problem hiding this comment.
This was the only linting violation I had to manually resolve, the rest were all minor things it seems. I don't think this breaks anything here?
There was a problem hiding this comment.
No, not seeing any issues here either
…website package.
joshJarr
force-pushed
the
chore/update-husky-pre-commit-for-website
branch
from
be63e80
to
a7784a9
Compare
…e-commit-for-website
This reverts commit 6c29ae0.
orvn
approved these changes
Jun 29, 2022
…e/update-husky-pre-commit-for-website
|
Cool, I'll merge this now, thanks @orvn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had issues committing code as pre-commit hooks could not find the husky config.
Huskys latest version no longer auto installs to align with npms best practices , so thought it best to use the latest version of the package.
So In this PR, to get things working I have:
.husky/pre-commitfor website package