-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: early adopter UI #1959
feat: early adopter UI #1959
Conversation
cmunns
commented
Sep 27, 2022
•
edited
Loading
edited
- Added TOS to free tier pre-upload
- Updated enterprise plan form inputs
- Added plan information to account page and removed default limit labels
- Added ui blocking overlay to tiers when tier is early adopter
- Updated tooltip text for tier table
- Remove first and last name boxes from Enterprise Query Form
- Early Adopters Account Page: their current storage limit will displayed and will stay the same as it was before and the progress bar will remain the same
- (Nice to have) Early Adopters Account Page Account Page remove: orange add you cc payment warning above the matrix (Free Tiers continue to see this warning)
- As a new user, on the payments page, when I select Lite or Expert, I must tick yes to “I have read and agree to the web3.storage Terms of Service" before being able to confirm (bolded text is linked to https://web3.storage/terms/).
- As a new user, on the accounts page, when I go to upload my first file, I must tick yes to “I have read and agree to the web3.storage Terms of Service" before being able to upload my file (bolded text is linked to https://web3.storage/terms/)
…paymentMethod=null but there is a subscription.storage.price to show
… of persistence in our miniflare setup - will reenable when time
… remove default limit
…/early-adopter-ui
…/early-adopter-ui
…age/web3.storage into feat/early-adopter-ui
packages/website/components/account/paymentTable.js/paymentTable.js
Outdated
Show resolved
Hide resolved
packages/website/components/account/storageManager/storageManager.js
Outdated
Show resolved
Hide resolved
packages/website/components/accountPlansModal/accountPlansModal.scss
Outdated
Show resolved
Hide resolved
packages/website/components/accountPlansModal/accountPlansModal.scss
Outdated
Show resolved
Hide resolved
import { userBillingSettings } from '../lib/api'; | ||
import { plansAll } from '../components/contexts/plansContext'; | ||
|
||
export const usePayment = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will you add a comment explaining what this is intended to be used for? How would another dev look at this and decide whether or not it's appropriate for their use case in another part of the codebase?
… lite to .20 addtlStorage
I haven't run the project locally for a while, so I'm not sure if this is related to this branch or not, but I get this after login: I'm also not seeing the TOS popup, which I think is because my |
I think the TOS thing from my last comment is caused by not setting up the stripe secrets locally. Will try that and do some more poking... |
Got things working locally - my existing account shows up as "early adopter" and a new address shows "Free" and gives me the TOS prompt 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around a bit, and everything seems to work as described when I run locally and nav to /account/payment
with an "early adopter" account and a "free" account.
I left a couple suggestions, but I don't think there's anything blocking or unsafe to merge in. BTW, the runtime error about pinning access shows up for me on main also, so I don't think it's related to this branch.
}; | ||
useEffect(() => { | ||
const acceptedTermsLocalStorage = localStorage.getItem('acceptedTerms'); | ||
console.log(acceptedTermsLocalStorage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably rm this console.log
or add some context so it's not just a random timestamp or null
<Dropzone | ||
className="file-uploader-dropzone" | ||
className={`file-uploader-dropzone ${ | ||
!hasPaymentMethod && currentPlan?.id === 'free' && !hasAcceptedTerms && 'disabled' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker at all, but when conditional chains get this long I like to pull them out into local vars, e.g. const dropZoneEnabled = thing && otherThing
.
🤖 I have created a release *beep* *boop* --- ## [2.22.0](website-v2.21.2...website-v2.22.0) (2022-09-29) ### Features * /account/login?redirect_to=/final/url should redirect to /final/url after authn ([#1950](#1950)) ([2bbe6de](2bbe6de)) * create page for service level agreement ([#1955](#1955)) ([6525845](6525845)) * early adopter UI ([#1959](#1959)) ([1affae3](1affae3)) * homepage (index) copy for pricing changes ([#1942](#1942)) ([f2084a3](f2084a3)) * new users are initialized into free tier ([#1945](#1945)) ([ee67c35](ee67c35)) * pricing page (for tiered pricing) ([#1894](#1894)) ([3f0db86](3f0db86)) * revert "fix: rm menu item from global account menu" ([#1951](#1951)) ([2f84754](2f84754)) * update preview summary metadata ([#1965](#1965)) ([a47949c](a47949c)) * update terms of service ([#1964](#1964)) ([dd810b9](dd810b9)) * update the web3storage product page (for tiered pricing) ([#1957](#1957)) ([03a6422](03a6422)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>