Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Genesis" still referenced in docs but not valid as per #2068 #3584

Closed
thecircleoflifefree opened this issue Jun 13, 2020 · 0 comments · Fixed by #3594
Closed

"Genesis" still referenced in docs but not valid as per #2068 #3584

thecircleoflifefree opened this issue Jun 13, 2020 · 0 comments · Fixed by #3594
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation

Comments

@thecircleoflifefree
Copy link

thecircleoflifefree commented Jun 13, 2020 •
edited
Loading

Expected behavior

Remove 'genesis' and keep 'earliest'

Actual behavior

'Genesis' is still referenced in the docs.

Steps to reproduce the behavior

You can go to version 1.2.9 getPastEvents and still see referenced 'genesis'

Error can be reproduced:

truffle(develop)> await instance.getPastEvents('Transfer',{fromBlock:'genesis', toBlock:'latest'}).then(function(ev){console.log(ev)})
Thrown:
Error: Given input "genesis" is not a number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updating docs: genesis is not a valid block identifier any longer
2 participants
@cgewecke @thecircleoflifefree