Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Diamonds #3589

Closed
mudgen opened this issue Jun 18, 2020 · 3 comments
Closed

Support for Diamonds #3589

mudgen opened this issue Jun 18, 2020 · 3 comments

Comments

@mudgen
Copy link

mudgen commented Jun 18, 2020

It would be great if web3.js provided support for deploying and upgrading diamonds. The Diamond Standard is here: ethereum/EIPs#2535

Here is an example of a tool (in Python) that helps manage diamonds: https://github.com/lampshade9909/DiamondSetter

Blog post about that tool: http://joeyzacherl.com/2020/06/diamond-setter-ethereum-smart-contract-manager/

@GregTheGreek
Copy link
Contributor

I've briefly gone over the draft EIP and it looks very interesting. This is a Dapp framework specific issue, perhaps if wider adoption came it would make sense to implement. That being said, I'm curious to hear what exactly you envision direct support to be?

@mudgen
Copy link
Author

mudgen commented Jun 29, 2020

@GregTheGreek Thanks for taking a look at this!

Support would be these things: Make it easier to deploy and upgrade diamonds. For example provide a function that takes a diamond proxy and a list of facet addresses and deploys them all and adds the facets to the diamond at the same time.

@GregTheGreek
Copy link
Contributor

It sounds like this might be better suited for an independent js tool in all honesty. Support for very specific EIP like this is a tough to draw the line at what should and shouldn't be included, as you can imagine there are a lot of EIPs.

I think we'll close this for now, but please feel free to re-open this in the future if you believe its gotten to the point where its very widely adopted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants