Fixe web3.eth.accounts encrypt/decrypt lib #1237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed privateKey from web3.eth.signTransaction and web3.eth.accounts.signTransaction documentation * removed privateKey from web3.eth.signTransaction and web3.eth.accounts.signTransaction documentation * added vscode to gitignore and minor doco change * Added test to show privateKey can not be passed to accounts.signTransaction * removed passing of private key * Added Eth.signTransaction function renamed accounts.privateToAccount to accounts.privateKeyToAccount Added missing Contract.options Added status to TransactionReceipt * reversing changes so my forked 1.0 branch is in sync with the upstream 1.0 branch
Docs currently show boolean, but it is returning a string
* Fixes in types definition * Fix Provider type: implement 'empty' variables to the other providers interfaces to make a OR between them
* First draft of babel+eslint+rollup * Moved to gulp 4, improved some logging output during builds. * Tweaks to the build process. * Fixing the versioning task. * Created separate copies of the .eslintrc files, one for each package.
* First draft of babel+eslint+rollup * Moved to gulp 4, improved some logging output during builds. * Tweaks to the build process. * Fixing the versioning task. * Created separate copies of the .eslintrc files, one for each package. * Started converting the first of the tests to es6. Started by converting HttpProvider to es6, which led to the conversion of contract.js, eth.sendTransaction.js, and setProvider.js Enabling ES6 support in Mocha led to fixes in method.buildCall.js and utils.sha3.js Fixed the problems in test/eth.sendTransaction.js that were causing the error "Transaction was not mined within 50 blocks, please make sure your transaction was properly send. Be aware that it might still be mined!". There may be deeper issues with the tests in eth.sendTransaction.js, these will require some conversation with Fabian before moving forward. * Fixing coverage problems by upgrading to nyc (the new istanbul) * Fixed test failure on node 8
* Converted the rest of the tests to es6 * Switched back to "dot" reporter for mocha. Removed stray console.error line that should not have been committed. Removed dead/commented console.log lines elsewhere in the code.
nicolaslawdune
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1071
Update crypto library.