Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 1.2.6 #3353

Closed
wants to merge 6 commits into from
Closed

Release - 1.2.6 #3353

wants to merge 6 commits into from

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Jan 31, 2020

Description

This release does add the Görli testnet to the ENS config and does update the Registry address.

This is a security patch release and should get published today.

Release Guideline

Added

Changed

Compare View

v1.2.5 -> v1.2.6

Type of change

  • Release

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested the minified file locally

…o ens config, new regsitry address defined in ens config, and related ens tests updated
@nivida nivida added In Progress Currently being worked on Release 1.x 1.0 related issues labels Jan 31, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 31, 2020

Coverage Status

Coverage decreased (-0.1%) to 85.36% when pulling c20bcf0 on release/1.2.6 into a121b6f on 1.x.

@nivida nivida mentioned this pull request Jan 31, 2020
10 tasks
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do whatever is necessary to update web3 - users who do not update will start seeing stale results on Monday, and we still need to encourage developers to use the new library once it is released!

@nivida
Copy link
Contributor Author

nivida commented Feb 2, 2020

@holgerd77 @michaelsbradleyjr @cgewecke @Arachnid version 1.2.6 of web3.js got successfully released.

@nivida nivida removed the In Progress Currently being worked on label Feb 2, 2020
@nivida nivida mentioned this pull request Feb 2, 2020
12 tasks
@nivida
Copy link
Contributor Author

nivida commented Feb 2, 2020

Closed because PR #3355 will apply those required changes on 1.x without reverting of improvements we already have done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants