Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternative method to display distributions in Data Explore section #334

Open
enemeth19 opened this issue Oct 20, 2021 · 8 comments
Labels
enhancement New feature or request on hold This issue might be worked on in the future

Comments

@enemeth19
Copy link
Collaborator

i.e., instead of pie charts

@rmoffitt
Copy link
Collaborator

It is nice that the pie charts show the frequency of some of these mutations- it doubles as a visualization for the user. You're right though, that there's not much of a benefit to the pie chart when the goal is to select subgroups.

@spencerkrichevsky spencerkrichevsky self-assigned this Oct 29, 2021
@spencerkrichevsky
Copy link

i.e., instead of pie charts

what do you think about stacked barplots? the x-axis could be gene names, the y-axis could be counts, and the color of each stack could be gene signature or clinical metadata

fake data example:
image

@enemeth19
Copy link
Collaborator Author

what do you think about stacked barplots?

This seems like an improvement to me. Thoughts? @19aanand @rmoffitt

@adit-anand
Copy link
Collaborator

I'm for this since it makes the raw counts easier to discern! To clarify, would the idea be to have a single, independently-rendered stacked bar for each clinical feature or gene?

@enemeth19
Copy link
Collaborator Author

enemeth19 commented Aug 12, 2022

would the idea be to have a single, independently-rendered stacked bar for each clinical feature or gene?

Yup, that was the idea (for genes)

@adit-anand
Copy link
Collaborator

Update from today's WebGen meeting:
For the version of the app we use in the manuscript that gets submitted, we will continue using pie charts for the Data Explore section. Future versions of the app may implement a new version of showing counts.

Should we close this issue and reopen it when we are focusing on adding new features?

@enemeth19
Copy link
Collaborator Author

Should we close this issue and reopen it when we are focusing on adding new features?

Sounds fine with me. We could do that or give it an "on hold" label

@rmoffitt rmoffitt added the enhancement New feature or request label Sep 21, 2022
@enemeth19
Copy link
Collaborator Author

Thoughts on addressing this issue before we publish the app? The more I think about doing so, the more it makes sense to me to serve our mission of facilitating intuitive/easy-to-use data exploration and cohort selection

@enemeth19 enemeth19 added the on hold This issue might be worked on in the future label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold This issue might be worked on in the future
Projects
None yet
Development

No branches or pull requests

4 participants