-
Notifications
You must be signed in to change notification settings - Fork 5
Rendering Issue with new Icons #14
Comments
It appears there's an issue with the path in the new icon? I followed the steps to properly download icons from the |
Hey, could you please check the steps described here https://github.com/webalys-hq/streamlinehq-npm#how-to-change-style-size-etc and check the example app as well https://github.com/webalys-hq/streamlinehq-npm/tree/master/docs/latest/example-app. There you will be able to find the way to change sizes of our SVGs. Please respond if this resolves your issue |
Hi @cbrwizard unfortunately I'm still having trouble. I think the issue is that there are hard coded |
@dkh215 how are you importing the image? I've just updated the example app with an exact image you're trying to use where I reduce its size to 16px. Here is the final result, it doesn't get cut. |
@cbrwizard interesting... I'm importing from the exact same path. I wonder if it's a compatibility issue with vue-svg-loader 🤔 , will dig into this. So weird. |
We're strongly considering wiping all height and width properties from our svgs and setting only viewBox instead (will do this for new icons packs at least). This should solve this issue. No ETA yet though as we're busy with releasing another feature right now |
I've just installed the NPM packages and that's a big issue for me, because these height & width properties are killing the "responsiveness" of the SVG icons (with the hard coded At this time I've added the |
Looks |
Proposed solution is to remove width and height params for all images and to set only viewbox param. |
Yup, setting a |
Width / height are going to be removed in the following release #23 and they will have |
We have recently recreated all assets and released a new NPM 3.0.1 version https://github.com/webalys-hq/streamlinehq-npm/releases/tag/3.0.1, please install it, fetch newest images and check if it helps you. Now width/height are removed, viewBox is added. |
Closing this issue since I believe it's fixed. Feel free to respond if you think otherwise |
Codepen Link
Old Icon vs New Icon
The text was updated successfully, but these errors were encountered: