Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/download-d8.sh seems broken #51

Closed
wanderer opened this issue Mar 11, 2016 · 5 comments
Closed

scripts/download-d8.sh seems broken #51

wanderer opened this issue Mar 11, 2016 · 5 comments

Comments

@wanderer
Copy link

I get

Downloading https://storage.googleapis.com/webassembly/v8-native-prototype/7ee0c81f107ab72d6e46d94e0a1d01be7ae56d34/d8...

curl: (22) The requested URL returned error: 404 Not Found
@binji
Copy link
Member

binji commented Mar 11, 2016

It uses the currently checked-out v8 submodule SHA to determine what to download. Are you on a local branch?

@wanderer
Copy link
Author

i'm on master

@wanderer
Copy link
Author

oh so it should be doing
https://storage.googleapis.com/webassembly/v8-native-prototype/63f35c26d6fadf8f6a6022f7a82f0701ad9c7a87/d8

But its getting the current commit hash for this repo 7ee0c81

@wanderer
Copy link
Author

i forgot git submodule update --init

@binji
Copy link
Member

binji commented Mar 11, 2016

Ah, I should probably add a check for that.

wenyongh pushed a commit to wenyongh/wabt that referenced this issue Jan 30, 2024
@matthias-blume
Adds header definitions for FP helper operations. (WebAssembly#51)
ebbf484 
* Some sandbox fixes.

* Adds header definitions for FP helper operations.

There are also some minor modifications to the current (temporary)
implementation of wasm_rt_trap, causing it to at least print the
name of the trapping condition to stderr.

An alternative (simpler) definition of load-store operations
has also been included, but it is not enabled by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wanderer @binji