Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider larger trees: 2^64 leaves #31

Closed
drewstone opened this issue Jan 12, 2021 · 3 comments
Closed

Consider larger trees: 2^64 leaves #31

drewstone opened this issue Jan 12, 2021 · 3 comments

Comments

@drewstone
Copy link
Collaborator

I know this would make the tree much larger, but I actually think we might want to support a larger tree from the get-go.

@drewstone
Copy link
Collaborator Author

As I continue to spec a larger system out, the complexity is growing, but also the need to make good design decisions for the future. If the future holds that we will use non-membership proofs as well, then we can consider storing nullifiers only once on chain for the time being and eventually off-chain once the tools are sufficient for it.

@lazovicff
Copy link
Contributor

lazovicff commented Jan 13, 2021

Making a tree bigger is merely changing a parameter. Underlying proof construction lib will dictate the scalability.
For supporting non-membership proofs we need to use a sparse Merkle tree with similar on-chain impl to #8

@drewstone
Copy link
Collaborator Author

Yea, we are missing from the SMT how we actually assign indices to leaf values. Right now, we just update at a given index in our tests which isn't exactly correct afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants