Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(repo): ESM Migration & Bump Deps #2331

Merged
merged 77 commits into from
May 31, 2024
Merged

ci(repo): ESM Migration & Bump Deps #2331

merged 77 commits into from
May 31, 2024

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented May 24, 2024 •
edited
Loading

Summary of changes

Provide a detailed description of proposed changes.

  • Removed unused anchors & signature bridge addresses in the config.
  • Migrated to Nx v19 which supports ESM migration and utilizes nx-release to improve the release process.
  • Migrated all libraries to ESM:
    • Updated the rollup build with consistent bundles & types.
    • Updated the tsc build for consistent bundles & types.
  • Migrated apps to ESM
  • Updated minimum requirement engines
    • Node >=18.12.x
    • Yarn 4.2.2
  • Bumped 88 dependencies & 164 dev dependencies with breaking changes
  • Upgraded to Storybook v8.1.1 with breaking changes
  • Removed Sentry on apps
  • Upgraded github action packages with breaking changes
  • Migrated to wagmi v2
  • Fixed the secondaryMessage not showing on the notification
  • Fixed rainbow wallet connection
  • Handled wallet not installed error with multiple injected providers by utilizing EIP-6963 providers
  • Migrated to Eslint v9 & Prettier v3
    • Tried flat config feature of eslint v9 but it seems nx still not supported flat config with esm modules pretty well!
  • Replaced built-in hooks with hooks from a library
  • Migrated to Modern Yarn v4

Instruction to migrate to Modern Yarn v4 (cc @yurixander @devpavan04 @vutuanlinh2k2)

  1. Make sure the minimum Node requirement >=18.12.x
  2. Run corepack enable to activate Corepack
  3. Go into your project directory
  4. Run yarn set version 4.2.2

For more information about the migration, refer to the Yarn documentation.

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/testnet-leaderboard
  • apps/faucet
  • apps/zk-explorer
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

@AtelyPham
chore(bridge-dapp): Removed unused anchors & bridges configs
40ecc48
@AtelyPham
ci(all): Migrate to Nx 17.0.0
2b3dea3
@AtelyPham
feat(all): Migrate to Nx 17.2 with breaking changes
fa9cf59
@AtelyPham
feat(repo): Migrate to Nx 18 with breaking changes
64f05eb
@AtelyPham
feat(repo): Migrate to Nx 19
184348f
@AtelyPham
Merge branch 'develop' into trung-tin/qa-rainbow-wallet-integration
c016def
@AtelyPham
ci(repo): Migrated dapp-types, browser-utils and icons libs to esm
db79ad6
@AtelyPham
ci(repo): Migrated tailwind-preset & note-manager to esm, move tsconf…
ac1b92c 
…ig to root tsconfig
@AtelyPham
ci(repo): Migrated webb-ui-components to esm
0b05d2a
@AtelyPham
chore(repo): Remove .js
e2a9bd4
@AtelyPham
ci(bridge-dapp): Migrate bridge dApp to ESM
c5089c3
@AtelyPham
ci(zk-explorer): Migrate ZK Explorer to ESM and bump deps
efeab6f
@AtelyPham
ci(tangle-dapp): Migrate Tangle dApp
eae08c4
@AtelyPham
ci(repo): Bump dependencies
b5902e1
@AtelyPham
ci(webb-ui): Upgrade to Storybook v8
12d5f59
@AtelyPham
ci(repo): Bump devDependencies with breaking changes
b171c9a
@AtelyPham
ci(repo): Bump remaining deps
7541b31
@AtelyPham
chore(repo): Remove Sentry
cb1ed99
@AtelyPham
chore(repo): Bump protocol-solidity packages and remove @polkadot/dev…
f54f407 
… from resolution
@AtelyPham
ci(repo): Upgrade Github Action packages and migrate release script t…
781945b 
…o esm
@AtelyPham
ci(webb-ui): Upgrade Storybook 8.1.1 with breaking changes
cf012e7
@AtelyPham
ci(repo): Migrate wagmi v2
75fdd3e
@AtelyPham
fix(webb-ui): Pass correct notification item props
2d0e28c
@AtelyPham
fix(tangle-dapp): Rainbow wallet connection
9db6870
@AtelyPham
chore(webb-ui): Handle wallet not install error
3fefbd2 
Handle wallet not install error inside the wallet connect modal
@AtelyPham
fix(repo): Fix eslint & prettier
7f11ce2
@AtelyPham
fix(tangle-dapp): Only emit newAccounts when the account is not disco…
401b527 
…nnected
@AtelyPham
ci(repo): Bump deps
8aa11fe
@AtelyPham
Merge branch 'develop' into trung-tin/esm-migration-and-upgrade-deps-2
926be32
@AtelyPham
fix(tangle-dapp): Modify export statements
07c26fb
AtelyPham and others added 16 commits May 29, 2024 20:55
@AtelyPham
fix(tools): Make husky files executable
d632b6a
@AtelyPham
Merge branch 'trung-tin/esm-migration-and-upgrade-deps' into trung-ti…
9731584 
…n/vite-migrations
@AtelyPham
fix(webb-ui): Fix Storybook build
f8e710f
@drewstone
Merge branch 'develop' into trung-tin/esm-migration-and-upgrade-deps
823d628
@AtelyPham
chore(repo): Removed deprecated Scroll testnet
b6a9e27
@AtelyPham
ci(repo): Bump deps, run lint
f4de973
@AtelyPham
Merge branch 'trung-tin/esm-migration-and-upgrade-deps' into trung-ti…
6b87066 
…n/vite-migrations
@AtelyPham
fix(tools): Make husky files executable
354f70b
@AtelyPham
Merge branch 'develop' into trung-tin/esm-migration-and-upgrade-deps
047d4e1
@AtelyPham
chore(repo): Run lint
fd5a557
@AtelyPham
Merge branch 'trung-tin/esm-migration-and-upgrade-deps' into trung-ti…
9d10ed9 
…n/vite-migrations
@AtelyPham
chore(repo): Temporary enable workflows for QA
4d39d4f
@AtelyPham
fix(tools): Fix type issue
8cfc2af
@AtelyPham
chore(repo): Removed the temporary branch
1d282b4
@AtelyPham
chore(repo): Review before merge
f7027f1
@AtelyPham
Merge pull request #2345 from webb-tools/trung-tin/vite-migrations
db54774
@devpavan04
Copy link
Member

Transfer (Substrate address to Substrate address and Substrate address to EVM address) ✅

CleanShot.2024-05-30.at.08.15.09.mp4

@devpavan04
Copy link
Member

First-time nominator (step 1 - select validators) runtime error ❌

CleanShot.2024-05-30.at.08.27.06.mp4

CleanShot 2024-05-30 at 08 27 50

@devpavan04
Copy link
Member

First-time nomination (Substrate) ✅

CleanShot.2024-05-30.at.08.42.52.mp4

@devpavan04
Copy link
Member

Add stake -bond extra (Substrate) ✅

CleanShot.2024-05-30.at.08.46.37.mp4

@devpavan04
Copy link
Member

Unbond (Substrate) ✅

CleanShot.2024-05-30.at.08.48.36.mp4

@devpavan04
Copy link
Member

Rebond (Substrate) ✅

CleanShot.2024-05-30.at.08.50.12.mp4

@devpavan04
Copy link
Member

devpavan04 commented May 30, 2024 •
edited
Loading

Change reward destination (Substrate) ✅

CleanShot.2024-05-30.at.08.56.54.mp4

@devpavan04
Copy link
Member

Stop nomination (Substrate) ✅

CleanShot.2024-05-30.at.09.08.52.mp4

@yurixander
Copy link
Member

yurixander commented May 30, 2024 •
edited
Loading

EVM transaction QA checklist:

  • Setup nominator
  • ⚠️ Update nominations
    • Won't let me update nominations / select other nominators:
      image
  • Bond more
  • Set payee
  • Unbond
  • Rebond
  • Withdraw
  • Transfer EVM -> Substrate
  • Transfer EVM -> EVM
  • Chill / stop nomination

@vutuanlinh2k2 vutuanlinh2k2 mentioned this pull request May 31, 2024
Merged
10 tasks
@AtelyPham AtelyPham merged commit 7876949 into develop May 31, 2024
11 checks passed
@AtelyPham AtelyPham deleted the trung-tin/esm-migration-and-upgrade-deps branch May 31, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurixander yurixander yurixander approved these changes

@devpavan04 devpavan04 devpavan04 approved these changes

@vutuanlinh2k2 vutuanlinh2k2 Awaiting requested review from vutuanlinh2k2

Assignees

@AtelyPham AtelyPham

Labels
needs review 👓 Pull request needs a review
Projects
Webb Universe
Status: Completed ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Migrate Applications and Libraries to ESM Format
4 participants
@AtelyPham @devpavan04 @yurixander @drewstone