Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection preventation during drag / resize does not work on floating panels. #54

Closed
bulentv opened this issue Jul 28, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@bulentv
Copy link
Contributor

bulentv commented Jul 28, 2015

Floating panels' DOM elements are moved out of the main container which is a common approach to set them free-moving. I think this causes here a side effect to temporary text selection disablement which is another necessity to prevent messing up the view during drag/resize operations.

Since the .wcDisableSelection is applied only to main container, floating panels are not taking it.
Preventing the text selection on the whole "body" would be a better action.

Please see the suggested fix

@Lochemage
Copy link
Contributor

@bulentv

You bring up a good point. It used to be that the floating panels appear inside the docker container element, but I have since moved it out so the panels can move more freely. I guess I forgot about the select class.

@Lochemage Lochemage added the bug label Jul 29, 2015
@Lochemage Lochemage added this to the 3.0.0 milestone Jul 29, 2015
@Lochemage Lochemage self-assigned this Jul 29, 2015
@Lochemage
Copy link
Contributor

@bulentv

I have move the class to the body element, let me know how that works for you.

@Lochemage
Copy link
Contributor

@bulentv

Closing this issue, please re-open if you find any problems with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants