Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.google.com - can't scroll the full body on findmydevice with overflow hidden #10113

Closed
webcompat-bot opened this issue Sep 19, 2017 · 11 comments
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-critical type-css Generic CSS issues
Milestone

Comments

@webcompat-bot
Copy link

URL: https://www.google.com/android/find?rapt=AEjHL4MPDX-Iq_DjGDRwhs-cwEQqo5bo3PHeCdfyFUg7LuSO--mT6W7huN2FO1BHQmCA5vdnNOCAJ_vFj6yj1_AeYqXQdNfNPA

Browser / Version: Firefox Mobile 57.0
Operating System: Android 6.0
Tested Another Browser: No

Problem type: Design is broken
Description: don't show all the page
Steps to Reproduce:

From webcompat.com with ❤️

@softvision-sergiulogigan

You need to login, but the user is right. The page cannot be scrolled in order to see all the contents.

screenshot-1505980856554

@karlcow karlcow added this to the needsdiagnosis milestone Oct 30, 2017
@karlcow
Copy link
Member

karlcow commented Jan 10, 2018

@softvision-sergiulogigan When I go this page being logged-in I get a map of where my device is.
Is it just in the activation phase?

@softvision-sergiulogigan

When I go this page being logged-in I get a map of where my device is.

that's the same for me, now.

Is it just in the activation phase?

I think so, yes. You get the dialogue on first use.

However, I cannot scroll the page even without the dialogue being displayed. Check Screen Capture.
No errors in the console.

screen capture video1

@karlcow
Copy link
Member

karlcow commented Jan 11, 2018

Ah interesting indeed. It almost looks like the issue I just diagnosed in #10088 unresponsive to touch for scrolling. I can move the map with two fingers, but indeed I can't scroll the rest of the area for accessing the hidden menus down the page. But maybe this is something different let's try to find out.

@karlcow
Copy link
Member

karlcow commented Jan 11, 2018

Ah in this case it is a lot simpler… There is an overflow-y: hidden on body and I guess because of the way the height of the viewport is computed with bottom menu and top bar. It gets different behavior in Firefox and Chrome.

body {
	height: 100%;
	overflow-x: hidden;
	overflow-y: hidden;
}

One solution would be for them to remove the overflow-y: hidden

body {
	height: 100%;
	overflow-x: hidden;
	/* overflow-y: hidden; */
}

@karlcow
Copy link
Member

karlcow commented Jan 11, 2018

I will do that, but at the same time I wonder if it's also part of our viewport work. ping @theres-waldo

@webcompat-bot webcompat-bot added the type-css Generic CSS issues label Jan 11, 2018
@webcompat-bot webcompat-bot modified the milestones: contactready, sitewait Jan 11, 2018
@karlcow
Copy link
Member

karlcow commented Jan 11, 2018

They have been contacted.

@karlcow karlcow changed the title www.google.com - design is broken www.google.com - can't scroll the full body on findmydevice with overflow hidden Jan 11, 2018
@RByers
Copy link

RByers commented Jan 16, 2018

At first I thought there was a Chrome/Firefox behavior difference here, but I confirmed that the overflow-x and overflow-y rules only appear when sending a Firefox UA string :-(

@miketaylr miketaylr added the engine-gecko The browser uses the Gecko rendering engine label Apr 30, 2019
@miketaylr
Copy link
Member

The bug still reproduces. :(

We can fix this via a CSS intervention, but I'll re-contact Google.

@ksy36
Copy link
Contributor

ksy36 commented Jul 31, 2019

Looked into this to see if we can add an intervention, however I get the same behavior in Chrome.

The page doesn't fit all the content and doesn't scroll:

Screenshot_2019-07-31-15-10-56
Screenshot_2019-07-31-15-11-12

So there is no difference in between Firefox and Chrome. Both get overflow-y: hidden;, though it doesn't seem to affect anything.

I guess, we can close this? @miketaylr

@softvision-oana-arbuzov
Copy link
Member

For me the scrolling works , thus the issue is fixed and the layout is the same for Firefox and Chrome.
image

Tested with:
Browser / Version: Firefox Nightly 68.0a1 (2019-08-01), Fenix 1.1.0 (Build #12042112) 📦: 4.0.1 🦎: 68.0-20190711090008
Operating System: LG G5 (Android 8.0.0) - 1440 x 2560 pixels (~554 ppi pixel density), Samsung Galaxy S7 Edge (Android 8.0.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine priority-critical type-css Generic CSS issues
Projects
None yet
Development

No branches or pull requests

7 participants