Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.huffingtonpost.fr - images overblown on mobile site #4114

Closed
webcompat-bot opened this issue Dec 28, 2016 · 12 comments
Closed

m.huffingtonpost.fr - images overblown on mobile site #4114

webcompat-bot opened this issue Dec 28, 2016 · 12 comments
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine
Milestone

Comments

@webcompat-bot
Copy link

URL: http://m.huffingtonpost.fr/2016/08/24/melenchon-applaudit-les-candidatures-de-montebourg-et-hamon-a-la/
Browser / Version: Firefox Mobile 52.0
Operating System: Android 6.0.1
Problem type: Mobile site is not usable

Steps to Reproduce

  1. Navigate to: http://m.huffingtonpost.fr/2016/08/24/melenchon-applaudit-les-candidatures-de-montebourg-et-hamon-a-la/

Expected Behavior:

Actual Behavior: text overflows

From webcompat.com with ❤️

@karlcow
Copy link
Member

karlcow commented Dec 29, 2016

When the article loads the pictures are at first at the right size, then suddenly get overblown.

It follows the css

.entry .author-card, .entry .author-list, .entry .top-media--image img {
	width: 100%;
}

so that's normal. There is probably something higher up in the hierarchy making the width bigger than what it is.

This is happening probably in .col

Ha! probably found!

#um_ultimedia_wrapper_wrap_widget_default #um_ultimedia_wrapper_list_ultimedia #um_ultimedia_wrapper_carousel_ultimedia {
	width: 20000em;
}

which translate to 240000px

The value is the same in Chrome fwiw but the interpretation by the rendering engines are different.

@karlcow
Copy link
Member

karlcow commented Jan 17, 2017

If I remove the html code for #um_ultimedia_wrapper_wrap_widget_default #um_ultimedia_wrapper_list_ultimedia #um_ultimedia_wrapper_carousel_ultimedia then the images are the right size.

but why the difference in between chrome and firefox here.
@dholbert

@dholbert
Copy link

dholbert commented Jan 17, 2017

This seems to be an issue with flexbox and the default min-width:auto behavior on flex items (which prevents flex items from being any smaller than their intrinsic sizes).

If I give min-width:0 to the img's .col ancestor, the issue seems to go away (in Firefox).

@dholbert
Copy link

So .col has an explicit width applied:

.col {
width: 100% !important;

...which should neuter the bad effects of min-width:auto here. But it's not having that effect in Firefox right now, for some reason.

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1331692 on this with a reduced testcase.

@karlcow
Copy link
Member

karlcow commented Jan 18, 2017

Thanks @dholbert

@karlcow
Copy link
Member

karlcow commented Mar 8, 2017

Just to keep the paper trail right. The correct dependency is now
https://bugzilla.mozilla.org/show_bug.cgi?id=1136312

Switching to needscontact

@karlcow
Copy link
Member

karlcow commented Mar 8, 2017

Let me switch again to needsdiagnosis.

What I noticed when the page is being displayed. The image fits right at first. But then they explode when the following script is loaded.

14:28:08.693 Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead[Learn More] 1 responsivev3-bis.js:1

capture d ecran 2017-03-08 a 14 29 03

ok I could fix it.

Currently they used:

.col {
	width: 100% !important;
	max-width: none !important;
	padding-left: 0;
	padding-right: 0;
}

If I replace with

.col {
	width: 100% !important;
	max-width: 100%;
	padding-left: 0;
	padding-right: 0;
}

switching again to needscontact

@karlcow
Copy link
Member

karlcow commented Mar 17, 2017

Their contact page gives an email address: aide@huffingtonpost.fr
http://www.huffingtonpost.fr/p/nous-contacter

@karlcow karlcow changed the title m.huffingtonpost.fr - mobile site is not usable m.huffingtonpost.fr - images overblown on mobile site Mar 17, 2017
@karlcow
Copy link
Member

karlcow commented Mar 17, 2017

screen shot 2017-03-17 at 10 44 21

@karlcow
Copy link
Member

karlcow commented Mar 17, 2017

Just contacted.

@karlcow
Copy link
Member

karlcow commented Mar 28, 2017

contacted also through the partner mailing list.

@adamopenweb
Copy link
Collaborator

This page no longer exists. Let's close in favour of #23259.

@adamopenweb adamopenweb modified the milestones: sitewait, duplicate May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox-mobile engine-gecko The browser uses the Gecko rendering engine
Projects
None yet
Development

No branches or pull requests

5 participants