Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty or unknown UA strings #1030

Closed
miketaylr opened this issue Apr 29, 2016 · 3 comments
Closed

Handle empty or unknown UA strings #1030

miketaylr opened this issue Apr 29, 2016 · 3 comments
Assignees
@miketaylr
Labels
type: bug

Comments

@miketaylr
Copy link
Member

To deal with part of #1009.
@miketaylr miketaylr self-assigned this Apr 29, 2016
@miketaylr
Copy link
Member Author

If you visit webcompat.com with an empty UA string:

@miketaylr
Copy link
Member Author

(wonder how many bots and scanners this prevented :p)

miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Remove unused get_browser_name helper method.
36751c0
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Get browser_name from the get_browser helper method.
e52200c
@miketaylr
Copy link
Member Author

Hm. Changed my mind on how I want to fix that part of the bug.

miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Make get_browser and get_browser_name tests more robust.
e376f1f
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Be sure to pass in browser_name when showing form errors.
8bd0a46
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Rewrite get_browser_name.
cbeff0f 
Give it a None default arg, in case it ever gets called without an arg.
Always return "unknown" by default.
If we get weird results back (i.e., "other"), normalize to "unknown".
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Rewrite get_os.
459346c 
Default None arg.
Return "Unknown" by default.
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Rewrite get_browser.
5eb5505 
Default None arg.
Return "Unknown" by default.
Switch position of "(Tablet)" modifier to come before the version string.
Normalize "Other" result to "Unknown" for weird values.
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Be more paranoid and make sure we have a string before p…
e4872e0 
…arsing a UA.
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Rewrite get_os.
b8105b9 
Default None arg.
Return "Unknown" by default.
Normalize "Other" to "Unknown"
Add tests.
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Rewrite get_browser.
43e1198 
Default None arg.
Return "Unknown" by default.
Switch position of "(Tablet)" modifier to come before the version string.
Normalize "Other" result to "Unknown" for weird values.
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Be more paranoid and make sure we have a string before p…
d066fc6 
…arsing a UA.
miketaylr pushed a commit that referenced this issue Apr 29, 2016
Issue #1030. Update docstrings for tests.
850098b
miketaylr pushed a commit that referenced this issue Apr 30, 2016
Issue #1030. Don't log exceptions when running locally.
b33fad8
miketaylr pushed a commit that referenced this issue May 2, 2016
Issue #1030. Add Fennec UA string with Android version to tests.
554b6cf
miketaylr pushed a commit that referenced this issue May 2, 2016
Issue #1030. Address review nits.
ea6d265
@karlcow karlcow closed this as completed in c66c939 May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow