Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how we submit a bug #2288

Closed
miketaylr opened this issue Mar 22, 2018 · 6 comments
Closed

Refactor how we submit a bug #2288

miketaylr opened this issue Mar 22, 2018 · 6 comments
Assignees
@miketaylr
Labels
lang: JS type: bug
Milestone
April / May / Jun...

Comments

@miketaylr
Copy link
Member

See #2276 (comment) and related discussion.

Basically, if/when an image is sent to upload.py and returns a 415, the bug report form should do something intelligent. At the very least, remove the problematic image and inform the user we don't like it.
@miketaylr
Copy link
Member Author

(this is a post refactor issue)

@miketaylr miketaylr mentioned this issue Mar 23, 2018
Closed
@Regaddi
Copy link
Member

Regaddi commented Apr 17, 2018

Is this still an "issue"?

image

@miketaylr
Copy link
Member Author

Is this still an "issue"?

I think so. I was just realizing the way we handle form submit is kinda... wonky.

Right now on submit we call maybeUploadImage, and rely on the success handler to submit the actual form. Obviously if we don't end up in success, that won't happen.

So probably maybeUploadImage needs to give control back to the onFormSubmit handler (which isn't on master right now, but comes from #2415) and decide what to do: either submit the form, or go into an error condition.

@miketaylr
Copy link
Member Author

go into an error condition.

#2276 (comment) is one idea to explore.

@miketaylr miketaylr added this to the April / May / June 2018 milestone Apr 23, 2018
@miketaylr miketaylr changed the title Gracefully handle 415 errors on the client side Refactor how we submit a bug Apr 23, 2018
@miketaylr
Copy link
Member Author

Changing the title, but we should be sure it also covers error conditions.

@miketaylr miketaylr self-assigned this Apr 23, 2018
@miketaylr
Copy link
Member Author

Would be nice to use Promises... or at least jQuery.Deferred. I wonder how painful an upgrade from jQ 1.11.X to 3.X would be (I'm pretty sure we don't try to support IE8 anyways)...

miketaylr added a commit that referenced this issue Apr 23, 2018
@miketaylr
Issue #2288. Unignore minified vendor code.
43d4705
miketaylr added a commit that referenced this issue Apr 23, 2018
@miketaylr
Issue #2288. Update Backbone to v1.3.3
6084419
miketaylr added a commit that referenced this issue Apr 23, 2018
@miketaylr
Issue #2288. Upgrade to jQuery v3.3.1.
fff176f
miketaylr added a commit that referenced this issue Apr 24, 2018
@miketaylr
Issue #2288. Make some jQuery v3 $.ajax fixes.
ea0eea1 
See https://jquery.com/upgrade-guide/3.0/#breaking-change-special-case-deferred-methods-removed-from-jquery-ajax
miketaylr added a commit that referenced this issue Apr 24, 2018
@miketaylr
Issue #2288. Add Backbone sourcemap.
23d8780
miketaylr added a commit that referenced this issue Apr 24, 2018
@miketaylr
Issue #2288. Use sendKeys for non-file inputs in comments-auth.js
c86ef02 
Also, bump the file upload timeout.
miketaylr added a commit that referenced this issue Apr 24, 2018
@miketaylr
Issue #2288. Use pressKeys for non-file inputs in comments-auth.js
682004b 
Also, bump the file upload timeout.
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Add a removeUploadPreview so it can be re-used.
9cbc666 
And organize some local variables as props on BugForm.
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Rewrite the image submission / form submission flow.
ab24269 
Now we use jQuery Deferreds (Promises/A+ compatible) to handle
success and error conditions. If an image passes validation on the server,
the issue will be sumitted. If there's a problem, it won't be submitted
and the user will have to upload a new image and try again.
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Fix a bug that slipped through codereview. Oops!
888c668
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Do the functional test timeout dance.
d67c5da
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Unignore minified vendor code.
a919bec
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Update Backbone to v1.3.3
d0f1a98
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Upgrade to jQuery v3.3.1.
1a43271
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Make some jQuery v3 $.ajax fixes.
11afae8 
See https://jquery.com/upgrade-guide/3.0/#breaking-change-special-case-deferred-methods-removed-from-jquery-ajax
miketaylr added a commit that referenced this issue Apr 26, 2018
@miketaylr
Issue #2288. Add Backbone sourcemap.
78a577d
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Run browsers headless by default, add --showBrowser to d…
aed24c2 
…isable.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add details and submit_type hidden inputs via form templ…
21bc561 
…ate.

And update their values via JS.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add a @mockable_report decorator so we can functionally …
6828b9c 
…test form submission.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add "0.json" fixture.
e459294
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Small tweaks to comments-auth.js.
c90ec33
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add pollUntil to FunctionalHelpers.
5713e01 
(and do some selenium hax for firefox so it works)
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add some issue creation functional tests.
dcdcbbd
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Whitespace fixes due to prettier upgrade.
d0bd0a1
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Run tests in Firefox 58.
ebda4a4
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Run browsers headless by default, add --showBrowser to d…
b8cd599 
…isable.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add details and submit_type hidden inputs via form templ…
4ce1e11 
…ate.

And update their values via JS.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add a @mockable_report decorator so we can functionally …
619284a 
…test form submission.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add "0.json" fixture.
817df78
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Small tweaks to comments-auth.js.
c35727b
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add pollUntil to FunctionalHelpers.
d7c4474 
(and do some selenium hax for firefox so it works)
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add some issue creation functional tests.
763518c
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Whitespace fixes due to prettier upgrade.
dac387a
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Run tests in Firefox 58.
9993475
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Run browsers headless by default, add --showBrowser to d…
5c192fb 
…isable.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add details and submit_type hidden inputs via form templ…
90ecdef 
…ate.

And update their values via JS.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Small tweaks to comments-auth.js.
642ef98
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add pollUntil to FunctionalHelpers.
d6ee695 
(and do some selenium hax for firefox so it works)
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Whitespace fixes due to prettier upgrade.
473dc67
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Run tests in Firefox 58.
678465d
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Run browsers headless by default, add --showBrowser to d…
31db9c9 
…isable.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Add details and submit_type hidden inputs via form templ…
ca700ed 
…ate.

And update their values via JS.
miketaylr added a commit that referenced this issue Apr 30, 2018
@miketaylr
Issue #2288. Move screenshot return value test to test_upload.py.
aae62e6
miketaylr added a commit that referenced this issue May 1, 2018
@miketaylr
Issue #2288. Move screenshot return value test to test_upload.py.
62f1452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
lang: JS type: bug
Projects
None yet
Milestone
April / May / June 2018
Development

No branches or pull requests
2 participants
@miketaylr @Regaddi