Remove top nav from about page

[miketaylr]

No description provided.

[miketaylr]

Hmmm, actually I'm wondering if @calexity wanted me to remove the entire nav, or just the About link?

I'll start with just about and we can nuke the whole thing if that was the intent.

[miketaylr]

I guess I changed my mind and removed both the about and github links from the top nav in ded5849. But, we can move them back (or do whatever we want).

The header does feel a bit empty now.

[calexity]

I just thought the nav should be in it's own block so it can apply to any
internal page. It shouldn't live in the About page, but I'm not sure where
to put it?

Does that make sense?

On Thu, Apr 17, 2014 at 8:34 AM, Mike Taylor notifications@github.comwrote:

I guess I changed my mind and removed both the about and github links from
the top nav in ded5849ded5849?utm_campaign=website&utm_source=sendgrid.com&utm_medium=email.
But, we can move them back (or do whatever we want).

The header does feel a bit empty now.
[image: screen shot 2014-04-17 at 10 33 32]https://cloud.githubusercontent.com/assets/67283/2733343/b58ce780-c645-11e3-82c8-8dcad4b64ec7.png?utm_campaign=website&utm_source=sendgrid.com&utm_medium=email

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/91?utm_campaign=website&utm_source=sendgrid.com&utm_medium=email#issuecomment-40727640
.

[miketaylr]

Aha, yeah it does. :) I'll pull it out into it's own partial "nav.html" that we can include in any page via

{% include "nav.html" %}

[miketaylr]

OK, I pulled the nav stuff into it's own file, @ "webcompat/templates/shared/nav.html" in 3830047.

I guess I should make it smart enough to not include the about link on the about page...

[calexity]

It can include all the links always and we can just highlight the page
we're on. I haven't settled on a great hover style, for now, I'm just
using black or #404040 which is dark grey.

On Thu, Apr 17, 2014 at 12:22 PM, Mike Taylor notifications@github.comwrote:

OK, I pulled the nav stuff into it's own file, @
"webcompat/templates/shared/nav.html" in 38300473830047
.

I guess I should make it smart enough to not include the about link on the
about page...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/91#issuecomment-40752384
.

[miketaylr]

Oh yeah, cool idea. I'll think of a way to pass in a selected class somehow...