Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1776. Update fixtures with some milestone info. #1788

Merged
merged 4 commits into from
Sep 12, 2017
Merged

Issue #1776. Update fixtures with some milestone info. #1788

merged 4 commits into from
Sep 12, 2017

Conversation

miketaylr
Copy link
Member

r=me

@miketaylr
Copy link
Member Author

(still more failures....)

@miketaylr miketaylr added this to the Milestones milestone Sep 7, 2017
@miketaylr
Copy link
Member Author

This issue is lame, I'll come back to it.

@miketaylr miketaylr self-assigned this Sep 8, 2017
@miketaylr miketaylr force-pushed the more-fixtures branch 3 times, most recently from a6214d6 to 84185ff Compare September 12, 2017 03:27
@miketaylr miketaylr mentioned this pull request Sep 12, 2017
Closed
@miketaylr
Copy link
Member Author

Most tests are failing with Expected [object Undefined] undefined to be a string -- which is #1809. But all of them pass in Chrome. Yay?

@miketaylr
Copy link
Member Author

Let's see if 3eae9cc will be any help -- later versions of digdug know about later versions of geckodriver.

@miketaylr
Copy link
Member Author

Let's see if 3eae9cc will be any help -- later versions of digdug know about later versions of geckodriver.

Sweet. That fixes the keys failures. Still a file upload failure, which is mozilla/geckodriver#858, but it has a workaround I'll try to use.

@miketaylr
Copy link
Member Author

6a73d83 is totally a guess... I don't even know if firefoxOptions is a thing. Intern docs mention a chromeOptions: https://theintern.io/intern/#runner-config

@miketaylr
Copy link
Member Author

bzzt no. https://travis-ci.org/webcompat/webcompat.com#L761

I'm just gonna merge this in (minus that commit) and file a new bug. Maybe @brizental will have some ideas.

@miketaylr
Copy link
Member Author

I'm just gonna merge this in (minus that commit) and file a new bug. Maybe @brizental will have some ideas.

Oh wait, I found some docs. Let me try once more. https://github.com/mozilla/geckodriver#firefox-capabilities

@miketaylr
Copy link
Member Author

Yay, green. I'm gonna merge.

@miketaylr miketaylr merged commit 63caeea into milestones Sep 12, 2017
@miketaylr miketaylr deleted the more-fixtures branch September 12, 2017 04:51
@miketaylr miketaylr mentioned this pull request Sep 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miketaylr miketaylr

Labels
type: testing
Projects
None yet
Milestone
Milestones
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miketaylr @karlcow