-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File upload no longer works with geckodriver 0.18.0 and Firefox 55 #858
Comments
#841 |
@Pilleo Looks like it -- this issue report has the trace level log though. |
@twalpole sure, I was just glad to see I am not the only one with the issue. |
@Pilleo Using Firefox Nightly, I’m successfully able to set the However, there are problems with the Get Element Property command which for some reason always appears to return an empty string. This doesn’t explain why you are seeing an invalid argument error. |
@andreastt I get the same result with nightly "57.0a1 (2017-08-08) (64-bit)" - Invalid Argument Error: File not found: ... |
Off the top of my head, this could be one of three things:
|
@andreastt 2 and 3 can be ruled out since it occurs on both macOS and linux (I haven't tested windows) and the file definitely exists and is not being run through Selenium Grid. The same code worked with the geckodriver 0.17.0 and FF 54, fails with 0.17.0/0.18.0 and FF 55. The code being run is the Capybara test suite. |
@andreastt |
On .NET on Windows it fails with an extra IndexOutOfBounds note, e.g.:
(and the actual exception is |
At least now it's behaving consistently with the behavior described in #644. |
I'm also now seeing this every time with FF 55.0 on Windows 7 and Windows 10. If I downgrade Firefox to 54.0.1 I don't get the "File not found" webdriver exception. I'm running with:
I'll see if I can reduce the reproduction as right now it's very complicated, and get some trace logs. |
Same for me: Arch linux, FF 55.0, geckodriver 0.18, selenium server 3.4.0. Fails on any file upload |
This might be a different issue than #644. Can anyone please run different versions of Firefox 55.0 beta? It would be good to know when this behavior exactly started to narrow down a possible regression, which seems to exist here maybe even in Firefox. Releases of Firefox beta you can find here: http://archive.mozilla.org/pub/firefox/releases/ Thanks. |
@whimboo From the Capybara Travis test logs - this worked with 55.0b10, started failing on 55.0b11 |
Ok, this is great info. So lets see what could be the cause here. Changes between those two betas are: Sadly I cannot see anything in that list of landed changes which would explain that behavior change. Can anyone else confirm this range? Otherwise I would have to try to repro it myself. Thanks. |
Or maybe it's a side-effect of bug 1372428 given that it's not only changing behavior for media plugins as stated. |
Confirm @twalpole experience - I have same regression 55.0b10 -> 55.0b11 |
Ok, I can reproduce it now and will investigate. Thanks for all the details and help! |
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1390486 and will let you know once it is fixed. |
Ok, so geckodriver misses to set the preference "dom.file.createInChild" to true. If you set this pref inside of firefoxOptions you can workaround this problem for now until it is fixed in 57.0 and most likely the next 56.0 beta. |
@whimboo Could this be fixed in a geckodriver release rather than having to wait for the next FF alpha/beta? Having to continuously tell people they can't actually test their apps with release versions of FF isn't great. |
Well, just use firefoxOptions and add the preference "dom.file.createInChild" set to true. It's the workaround for now which even works with geckodriver 0.18. |
@whimboo Yes, but that's one more thing to document for users that could (should?) just be automatically handled by a geckodriver minor release. |
We will release a new version when it's ready. So far this problem is not that wide-spread and we have a workaround. |
@valentjedi I don't work with Rust, and the source has recently moved off GitHub into Mozilla central, making PRs a bit more difficult to submit. |
I already landed the fix for geckodriver. With tomorrow's nightly it will
work without the workaround. I will request uplift to beta a day later.
Am 15.08.2017 8:56 nachm. schrieb "Thomas Walpole" <notifications@github.com
…:
@valentjedi <https://github.com/valentjedi> I don't work with Rust, and
the source has recently moved off GitHub into Mozilla central, making PRs a
bit more difficult to submit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#858 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAH6Q9yMz0DdN2K6b1_gR0xg4nLKMrK7ks5sYem4gaJpZM4Ov5Jn>
.
|
Just in case anyone else is looking for a workaround in phpunit-selenium: |
@bc-joshroe It would be better to send the preference as a capability:
|
The patch landed for beta and will be part of the next 56.0b4 release. |
This is still an issue with geckodriver 0.18 and Firefox 55.0.2, but the "dom.file.createInChild" fix still works. |
Please read #858 (comment) how to workaround that. I'm going to lock the conversation now given that we don't need more |
System
Setting a file to an <input type="file"> element fails with a InvalidArgumentError - "File not found".
This previously worked with geckodriver 0.17.0 and FF 54. The file definitely exists
Trace-level log
The text was updated successfully, but these errors were encountered: