-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The BIG Refactor #2039
Merged
The BIG Refactor #2039
Changes from all commits
Commits
Show all changes
400 commits
Select commit
Hold shift + click to select a range
2eeffe6
Issue #2017 - fix watch task and postcss
zoepage b4d9d1a
Issue #2012 - normalize dropdown
zoepage 766d261
#2012 #2017 - fix svg + add search
zoepage 9a4c4ec
Issue #2012 - fix z-index for dropdown
zoepage 510e8cb
Issue #2012 - fix z-index for nav
zoepage d2ce836
Issue #2012 - fix pagination
zoepage 920b671
Issue #2012 - remove double headline
zoepage 00218ce
Issue #2012 - fix search-bar z-index
zoepage 681fb7d
Issue #2012 - fix grid for new issue
zoepage 31d5888
FIX - broken css build
zoepage 90654a8
Issue #2037 - moved min.css to dist folder
zoepage 1c3b24b
Issue #1891. Remove redudant <label> and change where we show image p…
miketaylr b04ce79
Issue #1891. Update image preview tests for new selector.
miketaylr 4856021
Issue #1891. Fix anonymous submit button type and name.
miketaylr 4b2dd40
Issue #1891. New Issue route needs a js-ReportForm parent like homepage.
miketaylr 5d6554f
Issue #1891. Get "remove image upload" working again.
miketaylr 2a33f2f
Issue #1891. Add rudimentary styles for image upload error.
miketaylr 226042c
Issue #1891 - remove unused wc- css styles
zoepage ba73678
Issue #1891 - changed error msg class
zoepage c79607d
Issue #1891 - added validation to input fields
zoepage a703358
Issue #1891 - fix height of upload label
zoepage 76e4e24
Issue #1891 - add upload add / remove, layout fixes
zoepage d257975
Issue #1891 - layout fixes + new validation svgs
zoepage 49a5be1
Issue #1891 - fix flash message for max upload size
zoepage 87fc5f4
Issues #1891 - revert temp fix for downsizing img
zoepage 6ff37bf
Issue 1891 - add error message for upload
zoepage 32bf87e
Fix merge conflict
zoepage c19a2a8
Issue #2011 - initial grid
zoepage c82010a
Issue #2011 - add comments
zoepage d176da3
Issue #2031 - Updated stylelint to v8
magsout 0341a8e
Issue #2031 - fixed deprecated rules
magsout 37db56c
Issue #2011 - fix broken layout in comment section
zoepage 1739e27
Issue #1891 - clean up SVGs
zoepage 81c2773
Issue #1891 - removed non-existing button css class
zoepage ff3bf92
Issue #1891 - fix double notification-info class
zoepage c026bc0
Issue #1891 - normalize z-index
zoepage e45e40a
Issue #2011 - add comment box
zoepage bb2d7f4
Issue #2011 - fix overflow in code snippet
zoepage 42edd50
Issue #2011 - fix grid padding overflow
zoepage 0b49226
Issue #2049 - added --fix option and lint only css/src
magsout 864e3be
Issue #1933 - Adds tests for new contributors section
karlcow ad94748
Issue #1933 - Adds routes for contributors section
karlcow 5a55c87
Issue #1933 - Adjusts the navigation for contributors section
karlcow db9c5fe
Issue #1933 - Adds templates to contributors: report bug
karlcow 5e76548
Issue #1933 - Adds content to contributors template: reproduce bug
karlcow cf29e53
Issue #1933 - Adds content for diagnose a bug
karlcow 2bd4213
Issue #1933 - Adds content to contributors template: site outreach
karlcow 7764956
Issue #1933 - Adds templates to contributors: build tools
karlcow bdf2400
Issue #1933 - Adds templates to contributors: web research
karlcow f244a75
Issue #1933 - Adds templates to contributors: organize events
karlcow 48dae35
Issue #2011 - added label box with labels
zoepage 6d42942
Issue #2011 - add new styles for label editor
zoepage 332a951
Issues #2011 - fix missing }
zoepage 97315c9
Issue #2011 - fix CSP issue caused by auto merge
zoepage 9c8a9d8
Issue #2011 - fix SVG position for upload
zoepage d7bbef9
Issue #2011 - fix milestone editor
zoepage 83ce148
Issue #2011 - fix max width for img in issue body
zoepage bdfcf99
Issue #2017 - lint CSS files
zoepage bb8c983
Issue #2017 - add webcompat.dev to linter
zoepage 2eee7c7
Issue #2017 - add webcompat.dev to lint:fix
zoepage f93c6a0
Issue #2017 - add CSS to pre-linter
zoepage f54620e
Issue #2012 - fixed search bar
zoepage af6c853
Issue #1933 - add sub nav structure
zoepage 04cc52e
Issue #2011 - remove unused tmpl
zoepage b2bcb28
Issue #2011 - fix code styling
zoepage b5ffdd2
Issue #2011 - fix tabs
zoepage d4291be
Issue #2012 - fix z-index + type of search button
zoepage e1a6167
Issue #1933 - fix positioning issue of chevron
zoepage 8e57631
Issue #1933 - move team section to contribute
zoepage d1e94bb
Issue #1933 - fix markup for templates
zoepage 38c30eb
Issue #1933 - add footer sub nav
zoepage cd230e7
Issue #2109. Make it possible to pass in functionalSuites via args.
miketaylr 45c3643
Issue #2109. Fix history navigation tests.
miketaylr d36bc56
Issue #2109. Remove spurious 0 in img src attribute.
miketaylr af282b0
Issue #2113. Fixes issues auth tests.
miketaylr 0725fbf
Issue #2108. Update selectors for some comments auth tests.
miketaylr bcbb39d
Issue #2098n - fixed position of search-bar on small screen
magsout cc89bef
Issue #2069 - added cursor point on pagination
magsout 2f0b1b4
Issue #2071 - fixes position of label-icon
magsout 63a17b1
Issue #2092. Prevent forms default action when adding a comment.
miketaylr 60106cd
issue #2079 - fixed position of dropdown
magsout d1bed1e
Issue #2090 - added sticky position to the right side menu on issue
magsout 0803210
Issue #2116. Fix milestones auth tests.
miketaylr e5add90
Fixes #2117. Fix milestones auth tests.
miketaylr 1dd28f1
fixes #2122. fix search-non-auth test
magsout 7cfc9b6
Issue #2124. Fix user activity non-auth tests.
miketaylr e91d032
Issue #2112. Fix issue-list-non-auth tests.
miketaylr 41288d6
Issue #2123. Fix user activity auth tests.
miketaylr a2cb68c
Issue #2111. Fix index non auth tests.
miketaylr e34694b
Issue #2121. Fix search auth tests.
miketaylr d09bbca
Issue #2121. Fix issues non auth tests.
miketaylr b185036
Issue #2115. Fix labels auth tests.
miketaylr 99d0ef1
Issue #2118. Fix new issue tests.
miketaylr b441244
Issue #2103 - added padding left red asterisk
magsout 30752e5
Issue #2120. Fix reporting non auth tests.
miketaylr 7925d56
Issue #2107. Remove contributors-non-auth.js.
miketaylr 2e13e41
Issue #2147 - fixes overflowting of long URLs
zoepage 3e2211e
Issue #2153 - fixes url of labels for search filtering
zoepage d4a32ac
Issue #2075 - added checkmarks for url + desc
zoepage ea7fb7f
Issue #2098 - added top position for search-bar
magsout 6e66a93
Issue #2163 - fixed position of dropdon on small screen
magsout 05c3bfe
Issue #2110. Move postMessage string into a reusable constant.
miketaylr b212195
Fix: Issue with 404 falling out of grid
mpaarating 6c088e1
Modify: The svg for the hero animation
b2bb3ec
Issue #2061 - Change titles to match svg element
a0e05d5
Issue #2110. Fix selectors.
miketaylr edbcadf
Issue #2110. Make linter happy.
miketaylr e3c529e
Issue #2110. Prevent svg children of buttons from stealing clicks.
miketaylr c593047
Issue #2110. Get a bunch of tests to pass on Travis.
miketaylr ddf16df
Issues #2075 - fixes validation checkmarks
zoepage dcc0697
Issue #2193. Define external intern config object.
miketaylr 52afe46
Issue #2193. Use yargs to gather commandline args.
miketaylr 451fc6b
Issue #2193. Add support for --grep=string w/ intern
miketaylr b16de25
Issue #2193. Update docs around running tests.
miketaylr e961aa1
Issue #2193. Document how to use --grep with intern tests.
miketaylr 88f37b2
Issue #2193. Update how we invoke tests in Travis.
miketaylr bc6e396
Issue #2074 - fix jumping error message
zoepage b05a66d
Issue #2101 - add margin to group form-elements
zoepage ce95914
Issue #2101 - add open sans to input fields
zoepage 3c7f778
Fixes #2171 - add test for 404 label search (#2191)
zoepage 4411b0f
Issue #2195. Change font-src policy to include all of https://fonts.g…
miketaylr fd69d45
Issue #2210. Add contact page edits.
miketaylr e95409c
Issue #2212. Add privacy content edits.
miketaylr 29fcf57
Fixes Issue #1924 make animation of bug in hero section run just once
deeptibaghel 54cce22
Issue #2208. Add edits to about page.
miketaylr ae53453
Fixes Issue #1924 - make animations of bug ..further refinements
deeptibaghel 18c1edb
fixes #2094
5fead8a
Fixes #2070. Changed wompats link from about to contributors
96ae9ee
Issue #2090 - make the label box container sticky & the inner scrolla…
magsout fa31890
Fixes #2081. Introduced flexbox styles for report buttons.
5fa11ab
Issue #2081. Changes according to review.
3ca3c52
Fixes #2218 Long size text overlap the check-marks
deeptibaghel 4a12c68
Issue #2224 #2164 - fixes nav jumps
zoepage 5d95cba
Issue #2224 - shorten text
zoepage 7f99dcc
Issue #2224 - unify text
zoepage e192c54
Fixes #2205. Refined margin and padding definitions for body and hero
c276275
Fixes #2205. Let hero expand to edges in mobile & tablet viewports
56a7014
Fixes #2205. Introduced new css variables for grid edges
5f47a28
Issue #2090 - fixes position of Label Editor
magsout 2f70dbf
Issue #2076 - fixed position of button of label editor
magsout 37343b5
Applied change requests from review.
e0ccdd0
Issue #2234 - empty search returns undefined
zoepage 21d2428
Issue #2134 - fixes fade in load page
magsout 1c45815
Issues #2088 - Add tiles section to index
zoepage 11a81cf
Fixes #2146. Minor refactoring for grid classes.
3d85d07
Further adjustments.
ac9d201
Fixes #2166. Set min-height on text-field
bcdf103
Fixes #2169. Stricter positioning rules for dropdown.
8699034
Issue #2083 - add slack to site
zoepage 0b6afc0
Issue #2076 - fixed position of button of label editor on small screen
magsout 7df2e38
Issue #2090 - removed not useful MQ
magsout b76e78a
Issue #2230 - Modify npm scripts to be uniform
mpaarating 93e0d3b
Removed top and bottom padding on new issue comment field.
ec2a337
Corrected grid definitions in combination with sub-navigation on cont…
a0eb78a
Fixes #2245. Avoid inline styles set with JS.
5c563fb
Fixes #2247. Corrected grid-nested.
1a1401c
Fixes #2248. Remove CSS nav-link class on Login link.
e3f2128
Issue #2152. Delete unused class.
miketaylr d8ad502
Issue #2152. Add a --color-first-constrast variable.
miketaylr db550b8
Issue #2152. Use notification-information for flashes by default.
miketaylr 2382a36
grid-nested now grows to full width.
3422820
Issue #2152. Tweak line-height for notifications.
miketaylr f1c06c8
Fix nested grid in issue details.
a0060f6
Finetuned issue detail view.
5b5889e
Correct width sizing of issue comments
ddbdbfb
Issue #1847 - add loader for upload
zoepage 8b796df
Scale images in comments correctly to prevent scrollbars
db35344
Issue #2244 - fixed position of label box on small screen
magsout e4f6d5d
Issue #2151. Add button-secondary style to anon button.
miketaylr 71ace10
Fixes #2258. Use antialiasing for fonts in Chrome.
51bd012
Fixes #2260 - Corrected cssmin grunt config
fdb8857
Fixes #2255 - Use xlink:href attribute for SVG references
65d92d5
Fixes #2087 - Show and hide navbar in dependency of scrolling
7142785
Fixes #2255 - Fix SVG references in JST templates
d2bd708
Changes from review
2462f30
Fixes #2165 - Activate HTML form validation for comment section
4a4b1d2
Fixes #2234 - Adjust regex for search param. Prevent empty topbar sea…
f5b47d8
Revert changes on the search form on issues page. Add required attrib…
20a5d80
Issue #1847 - fix lint issues
zoepage 3be034e
Issue #1847 - remove hide class
zoepage 203e13a
Issue #2262. Fix some milestone template copypasta.
miketaylr b731c8d
Issue #2262. label reRender should get remoteName, not color.
miketaylr f69a754
Issue #2262. Remove notion of milestones having a color.
miketaylr a575a25
Issue #2262. Remove leftover boilerplate.
miketaylr b1e473e
Removed required field on issue list search field
d0fd366
Issue #2155 - add thanks.jst msg
zoepage 18ccec6
Fixes #2277 - Add missing border colors for status labels
1444ced
Issue #1847 - add loader to form on submit
zoepage 9274198
Issue #1933 - Added copy fixes to index
zoepage f646593
Issue #1933 - Added copy fixes to contact
zoepage 60afb69
Issue #1933 - Added copy fixes to privacy
zoepage 981624d
Issue #1933 - Added copy fixes to contributors/report-bug
zoepage 1b0db85
Issue #1933 - Added copy fixes to contributors/reproduce-bug
zoepage 75aafb0
Issue #1933 - Added copy fixes to contributors/diagnose-bug
zoepage 2531072
Issue #1933 - switch absolute links to relative links
zoepage a984e8d
Issue #1933 - Added copy fixes to contributors/site-outreach
zoepage 767bfd6
Issue #1933 - add target blank to all external links
zoepage d2d4c5f
Issue #1933 - fix copy for contributors/site-outreach
zoepage 078cd4b
Issue #1933 - add copy fixes to contributors/build-tools
zoepage 14b4cb0
Issue #1933 - add copy fixes to contributors/organize-webcompat-events
zoepage e7a5439
Corrected colors for status labels
54d2353
Fixes #2128 - Harmonize sizes of new comment and upload area
a8a3ccc
Expand submit button
f0df6a0
Fixes #2274 - Automatic scrolling of label box when editing
20765a6
Fixes #2269 – Smoothen navbar transition
ae47e57
Fixes #2281 - Allow upload info box to expand
d07e1bb
No issue. Fix new (post-rebase) test failures on refactor branch.
miketaylr 2fcb369
Fix two typos
zoepage facee47
Issue #2216 - update screenshots
zoepage 9d3212a
Issue #2216 - update screenshots
zoepage 99e2867
Issue #2216 - Include screenshots as images. Still needs style tweaks.
e436494
Issue #1847 - add error handeling + stop animation
zoepage 0e353e7
Fixes #2085. Fix remaining review typos.
miketaylr a912c71
Issue #2085. Fix (unrelated) style lint error.
miketaylr 6ace3b5
Issue #2296 - send patch for lost commits
zoepage 2589a4e
Merge pull request #2297 from webcompat/merge-fix-patch
78be887
Fixes #2299 - Add grid-row for correct spacing to hero-tile
fa9211f
Fixes #2301 - Upload input size equals hoverable area
74dfe77
Fixes #2299 - Move left grid margin on issue-description to padding
989ae57
Fixes #2301 - Remove upload is clickable on full area
e5014de
Issue #2306 - add purifyCSS
zoepage c44c550
Issue #2306 - remove unused files
zoepage fe7aa74
Issue #2310 - remove XML declaration
zoepage 13f849e
Issue #2312 - remove href from button
zoepage 3eb4d79
Fixes #2258 - Remove blurring transform translateX in navigation bar
a26349e
Issues #2308 - fix aspect ratio in comment img
zoepage 6173eb9
Merge pull request #2315 from webcompat/issues/2258-1
zoepage 3e312e1
Merge pull request #2305 from webcompat/issues/2301
zoepage c886088
Merge pull request #2304 from webcompat/issues/2299
zoepage 08e0644
Merge pull request #2316 from webcompat/issues/2308
zoepage 67941bb
Issue #2317 - remove gray border of sub-nav
zoepage a7dbbdd
Issue #2319 - remove unused css class in js
zoepage d500d34
Issue #2322 - change fix to lint:fix
zoepage 43d1e29
Issue #2324 - add js class to separate css and js functionality
zoepage f3f571f
Issue #2204 - add license info of new icon set
zoepage 41f9e5f
Issue #2216 - add screenshots
zoepage 527d039
Merge pull request #2311 from webcompat/issues/2310
71be5d4
Merge pull request #2313 from webcompat/issues/2312
b70083e
Merge pull request #2318 from webcompat/issues/2317
aecafd2
Merge pull request #2321 from webcompat/issues/2319
101e20c
Merge pull request #2325 from webcompat/issues/2324
80aeee5
Merge pull request #2327 from webcompat/issues/2204
a93fec0
Merge pull request #2328 from webcompat/issues/2216-2
e5a0a45
Issue #2322 - update docs
zoepage 1f5652e
Merge pull request #2323 from webcompat/issues/2322
07b0f3a
Merge pull request #2309 from webcompat/issues/2306
f80bec5
Issue #2329 - remove inline style
zoepage 6a66f4e
Merge pull request #2333 from webcompat/issues/2329
3b9f637
Issue #2334. Ensure that we consider browser-sent images as valid.
miketaylr 2711abe
Merge pull request #2335 from webcompat/issues/2334/1
zoepage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
module.exports = function(grunt) { | ||
grunt.config("purifycss", { | ||
options: { | ||
rejected: true, | ||
info: true | ||
}, | ||
target: { | ||
src: [ | ||
"webcompat/templates/*.html", | ||
"webcompat/templates/**/*.html", | ||
"webcompat/templates/**/*.jst", | ||
"webcompat/static/js/*.js" | ||
], | ||
css: ["webcompat/static/css/*.css", "webcompat/static/css/src/*.css"], | ||
dest: "tmp/purestyles.css" | ||
} | ||
}); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
tests/fixtures/api/issues.2c36ce8c0fec0c185101ba8f6b203f48.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"_fixture": true, | ||
"total_count": 0, | ||
"incomplete_results": false, | ||
"items": [] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
Sorry, something went wrong.