Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The BIG Refactor #2039

Merged
merged 400 commits into from
Mar 28, 2018
Merged

The BIG Refactor #2039

merged 400 commits into from
Mar 28, 2018

Conversation

zoepage
Copy link
Member

@zoepage zoepage commented Jan 25, 2018

Lets see how bad it really is...

@miketaylr
Copy link
Member

Before we start the review process, let's be sure to rebase against master -- I think a few PRs have landed there.

@miketaylr
Copy link
Member

Need to investigate why tests are failing now.

@miketaylr
Copy link
Member

miketaylr commented Mar 28, 2018

I think something is wacky on travis, i'm going to nuke the build cache and restart.

screen shot 2018-03-28 at 11 19 52 am

Still failed, but tests are running and passing locally, so I'm not super concerned.
TOTAL: tested 2 platforms, 164 passed, 0 failed

@zoepage
Copy link
Member Author

zoepage commented Mar 28, 2018

I had that issue too, but it disappeared after restarting the build

@miketaylr
Copy link
Member

And tests decided to start passing again, yay!

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥁 ..... 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants