Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShadyCSS] Add support for calling prepareTemplate for a given name more than once. #19

Open
sorvell opened this issue May 3, 2018 · 2 comments

Comments

@sorvell
Copy link
Collaborator

sorvell commented May 3, 2018

This should provide better integration with [lit-html'(https://github.com/Polymer/lit-html)s shady-render functionality. Currently, @apply will not correctly track properties when prepareTemplate is called multiple times, losing the previously tracked properties for a given mixin.

@schalkneethling
Copy link

I second this. My usage is not in the same context but, not having to dynamically remove and create a new template element between each call to prepareTemplate would be great.

I know the flag _prepared is set on the template element[1] and if this is true the function bails. Perhaps one can pass { force: true } to indicate to the function that it should ignore the value of _prepared and do its thing again? I can see that being useful. Thanks!

[1] https://github.com/webcomponents/shadycss/blob/master/src/scoping-shim.js#L78

@dfreedm dfreedm transferred this issue from webcomponents/shadycss Jun 6, 2019
@dfreedm dfreedm changed the title Add support for calling prepareTemplate for a given name more than once. [ShadyCSS] Add support for calling prepareTemplate for a given name more than once. Jun 12, 2019
@dfreedm dfreedm added Severity: High Type: Feature New feature or request labels Jun 12, 2019
@stale
Copy link

stale bot commented Apr 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants