Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

native-shim HTMLElement prototype is the old function? #546

Closed
trusktr opened this issue Jun 1, 2016 · 2 comments
Closed

native-shim HTMLElement prototype is the old function? #546

trusktr opened this issue Jun 1, 2016 · 2 comments

Comments

@trusktr
Copy link

trusktr commented Jun 1, 2016

I see the line

  HTMLElement.prototype = Object.create(origHTMLElement);

But should it be

  HTMLElement.prototype = Object.create(origHTMLElement.prototype);

? If the prototype is the origHTMLElement, that would mean that the origHTMLElement.* static properties will be HTMLElement instance properties?

@ebidel ebidel added the CE v1 label Jun 8, 2016
@justinfagnani
Copy link
Contributor

I think I just fixed this, though I admittedly don't have tests for the shim.

@notwaldorf
Copy link
Contributor

This issue was moved to webcomponents/custom-elements#51

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants