Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloadSession doesn't work in Appium #3494

Closed
xlenz opened this issue Feb 4, 2019 · 1 comment · Fixed by #3506
Closed

reloadSession doesn't work in Appium #3494

xlenz opened this issue Feb 4, 2019 · 1 comment · Fixed by #3506
Labels

Comments

@xlenz
Copy link

xlenz commented Feb 4, 2019

Environment (please complete the following information):

  • WebdriverIO version: 5.4.13
  • Mode: WDIO Testrunner

Config of WebdriverIO
Use Appium

Describe the bug
reloadSession doesn't work when using Appium because sessionId is not set (it is missing in response)

To Reproduce
reloadSession()

Expected behavior
reloadSession should get sessionId in same way as newSession.
I mean this (response.value.sessionId || response.sessionId)

Log
not needed

Additional context

const response = await sessionRequest.makeRequest(this.options);
const newSessionId = response.sessionId;
// sessionId is missing in response. It should be value.sessionId in this case
value: {
  capabilities: {...}
  sessionId:"1cb617c2-31b7-4d7c-bfb8-25f7fb9f1219"
}
@xlenz
Copy link
Author

xlenz commented Feb 4, 2019

will do PR for this

@mgrybyk mgrybyk mentioned this issue Feb 5, 2019
6 tasks
christian-bromann pushed a commit that referenced this issue Feb 5, 2019
## Proposed changes

## Types of changes

[//]: # (What types of changes does your code introduce to WebdriverIO?)
[//]: # (_Put an `x` in the boxes that apply_)

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added necessary documentation (if appropriate)

## Further comments

fix #3494 

webdriver typings and webdriverio docs have to be generated before releasing 

### Reviewers: @webdriverio/technical-committee
yamkay pushed a commit to MoveInc/webdriverio that referenced this issue Jun 13, 2019
## Proposed changes

## Types of changes

[//]: # (What types of changes does your code introduce to WebdriverIO?)
[//]: # (_Put an `x` in the boxes that apply_)

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added necessary documentation (if appropriate)

## Further comments

fix webdriverio#3494 

webdriver typings and webdriverio docs have to be generated before releasing 

### Reviewers: @webdriverio/technical-committee
yamkay pushed a commit to MoveInc/webdriverio that referenced this issue Sep 4, 2019
## Proposed changes

## Types of changes

[//]: # (What types of changes does your code introduce to WebdriverIO?)
[//]: # (_Put an `x` in the boxes that apply_)

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added necessary documentation (if appropriate)

## Further comments

fix webdriverio#3494 

webdriver typings and webdriverio docs have to be generated before releasing 

### Reviewers: @webdriverio/technical-committee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants