Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Appium reload session #3506

Merged
merged 2 commits into from Feb 5, 2019
Merged

Fix Appium reload session #3506

merged 2 commits into from Feb 5, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Feb 5, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

fix #3494

webdriver typings and webdriverio docs have to be generated before releasing

Reviewers: @webdriverio/technical-committee

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #3506 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3506   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files         131     131           
  Lines        2962    2962           
  Branches      648     649    +1     
======================================
  Hits         2894    2894           
  Misses         64      64           
  Partials        4       4
Impacted Files Coverage Δ
.../webdriverio/src/commands/browser/reloadSession.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f09ad...9a32519. Read the comment docs.

@xlenz
Copy link

xlenz commented Feb 5, 2019

please merge if there are no comments

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Feb 5, 2019
@christian-bromann christian-bromann merged commit 5cde958 into webdriverio:master Feb 5, 2019
@mgrybyk mgrybyk deleted the fix-appium-reload-session branch February 21, 2019 12:20
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Jun 13, 2019
## Proposed changes

## Types of changes

[//]: # (What types of changes does your code introduce to WebdriverIO?)
[//]: # (_Put an `x` in the boxes that apply_)

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added necessary documentation (if appropriate)

## Further comments

fix webdriverio#3494 

webdriver typings and webdriverio docs have to be generated before releasing 

### Reviewers: @webdriverio/technical-committee
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
## Proposed changes

## Types of changes

[//]: # (What types of changes does your code introduce to WebdriverIO?)
[//]: # (_Put an `x` in the boxes that apply_)

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added necessary documentation (if appropriate)

## Further comments

fix webdriverio#3494 

webdriver typings and webdriverio docs have to be generated before releasing 

### Reviewers: @webdriverio/technical-committee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reloadSession doesn't work in Appium
3 participants