-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(mock): 'matches' -> 'calls' property #10129
Conversation
Thanks for raising the PR. I think this is an issue with the docs. The user is suppose to use |
Ok, i will update the docs in this PR. Also, about mocks: i need an ability to check if mock (spy) has some pending requests. Will you approve a feature, which emits something like |
Seems like a reasonable feature request. Yeah totally!
For WebDriver we will have to use the new WebDriver Bidi features which have not landed yet. While you can already get request information, it is not yet possible to mock/replace requests and responses. So we can ignore this for now and have it throw an |
calls
property
calls
property
Also, do you mind if i add documentation about |
Good call, let's add it to https://webdriver.io/docs/api/environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Proposed changes
Change
Mock
interface in docs (usecalls
property instead ofmatches
)Types of changes
Checklist
Reviewers: @webdriverio/project-committers