Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Migrate to Husky v9 #12395

Merged
merged 1 commit into from Mar 3, 2024
Merged

Conversation

seanpoulter
Copy link
Contributor

Proposed Changes

Husky was updated to v9 without following the How to Migrate docs. This is similar to webdriverio-community/wdio-electron-service#447.

  • Update the "prepare" npm script
  • Remove the shebang from the Git hooks

Husky v9 is in the v8 branch but it's probably not worth back-porting. They should be backwards compatible changes for Husky v9.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👌

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Mar 3, 2024
@christian-bromann christian-bromann merged commit 7507b83 into webdriverio:main Mar 3, 2024
3 of 8 checks passed
@seanpoulter seanpoulter deleted the husky@9 branch March 12, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants