Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Eslint enforcements #3144

Merged
merged 2 commits into from
Dec 18, 2018
Merged

More Eslint enforcements #3144

merged 2 commits into from
Dec 18, 2018

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch adds enforcement of single quotes and no semicolons.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Dec 17, 2018
@christian-bromann christian-bromann self-assigned this Dec 17, 2018
@christian-bromann christian-bromann requested a review from a team December 17, 2018 23:07
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #3144 into master will decrease coverage by <.01%.
The diff coverage is 97.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3144      +/-   ##
==========================================
- Coverage   96.74%   96.74%   -0.01%     
==========================================
  Files         129      130       +1     
  Lines        2738     2737       -1     
  Branches      579      579              
==========================================
- Hits         2649     2648       -1     
  Misses         79       79              
  Partials       10       10
Impacted Files Coverage Δ
...s/wdio-allure-reporter/tests/__fixtures__/suite.js 100% <ø> (ø) ⬆️
...es/webdriverio/src/commands/element/dragAndDrop.js 100% <ø> (ø) ⬆️
.../wdio-allure-reporter/tests/__fixtures__/runner.js 100% <ø> (ø) ⬆️
packages/wdio-concise-reporter/tests/fixtures.js 100% <ø> (ø) ⬆️
packages/wdio-mocha-framework/src/utils.js 100% <ø> (ø) ⬆️
packages/webdriverio/src/utils.js 100% <ø> (ø) ⬆️
...wdio-allure-reporter/tests/__fixtures__/command.js 100% <ø> (ø) ⬆️
packages/webdriverio/src/commands/browser/keys.js 69.23% <0%> (ø) ⬆️
.../webdriverio/src/commands/element/selectByIndex.js 75% <0%> (ø) ⬆️
packages/webdriverio/src/commands/browser/url.js 100% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2977e0c...5929c2c. Read the comment docs.

@christian-bromann
Copy link
Member Author

Moving forward with this. If anyone has any objections I am happy to open a follow up PR.

@christian-bromann christian-bromann merged commit 61754a8 into master Dec 18, 2018
@christian-bromann christian-bromann deleted the cb-eslint-fixes branch December 18, 2018 09:05
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Jun 13, 2019
* enforce no semicolons

* enforce single quotes
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
* enforce no semicolons

* enforce single quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant