Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriverio: Update changelog for cli array arguments #3220

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

WillBrock
Copy link
Member

Proposed changes

--spec and --suite has changed from a string argument to an array in v5. This updates the changelog with those changes.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Reviewers: @webdriverio/technical-committee

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #3220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3220   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         130      130           
  Lines        2773     2773           
  Branches      592      592           
=======================================
  Hits         2673     2673           
  Misses         90       90           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972e667...8ac76f6. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jan 2, 2019
@christian-bromann christian-bromann merged commit f99964b into webdriverio:master Jan 2, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Jun 13, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants