webdriverio: updating screenshot call to handle backslash #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3251 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 131 131
Lines 2814 2814
Branches 607 607
=======================================
Hits 2714 2714
Misses 90 90
Partials 10 10
Continue to review full report at Codecov.
|
christian-bromann
requested changes
Jan 5, 2019
| @@ -32,7 +32,7 @@ export default async function saveScreenshot (filepath) { | |||
| throw new Error('saveScreenshot expects a filepath of type string and ".png" file ending') | |||
| } | |||
|
|
|||
| const absoluteFilepath = filepath.startsWith('/') | |||
| const absoluteFilepath = filepath.startsWith('/') | filepath.startsWith('\\') | |||
There was a problem hiding this comment.
It should be a proper OR
const absoluteFilepath = filepath.startsWith('/') || filepath.startsWith('\\')There was a problem hiding this comment.
Yeah, somehow I missed that it wasn't, will update
christian-bromann
requested changes
Jan 6, 2019
|
|
||
| it('should not change filepath if starts with forward slash', async () => { | ||
| const fs = require('fs').default | ||
| fs.existsSync = () => true |
There was a problem hiding this comment.
since fs is already a mock, let's use mockReturnValue here
There was a problem hiding this comment.
Something like this? Whenever I try that it tells me that mockReturnValue is not a function
const fs = require('fs').default
fs.existsSync.mockReturnValue(false)
spy = jest.spyOn(fs, 'writeFileSync')
There was a problem hiding this comment.
What is fs.existsSync?
There was a problem hiding this comment.
to use mockReturnValue it needs to be jest.fn(). Just updated it in the fs.js mock.
|
|
||
| it('should not change filepath if starts with backslash slash', async () => { | ||
| const fs = require('fs').default | ||
| fs.existsSync = () => true |
|
|
||
| it('should change filepath if does not start with forward or back slash', async () => { | ||
| const fs = require('fs').default | ||
| fs.existsSync = () => true |
| @@ -1,4 +1,4 @@ | |||
| const fs = jest.genMockFromModule('fs') | |||
| fs.writeFileSync = jest.fn() | |||
| fs.writeFileSync = (path, data, options) => path | |||
There was a problem hiding this comment.
We can then revert this change
christian-bromann
added
the
PR: Polish 💅
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Jun 13, 2019
…o#3251) ## Proposed changes Updating the ```saveScreenshot``` method to be able to start with a backslash. ## Types of changes [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments I wanted to introduce this because when trying to save a screenshot to a network location the filepath starts with ```\\\\``` (Two backslashes and two escape characters). Before this, it would just append the server path to the current directory. ### Reviewers: @webdriverio/technical-committee
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
…o#3251) ## Proposed changes Updating the ```saveScreenshot``` method to be able to start with a backslash. ## Types of changes [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments I wanted to introduce this because when trying to save a screenshot to a network location the filepath starts with ```\\\\``` (Two backslashes and two escape characters). Before this, it would just append the server path to the current directory. ### Reviewers: @webdriverio/technical-committee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating the
saveScreenshotmethod to be able to start with a backslash.Types of changes
Checklist
Further comments
I wanted to introduce this because when trying to save a screenshot to a network location the filepath starts with
\\\\(Two backslashes and two escape characters). Before this, it would just append the server path to the current directory.Reviewers: @webdriverio/technical-committee