Update getting started doc #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds requirement to run `npm init -y`, as the cli config auto-install has trouble otherwise - Adds some spacing to help with readability - Specifies that you need Firefox installed to use Geckodriver - Updates test runner section with a few more details
Codecov Report
@@ Coverage Diff @@
## master #3576 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 136 136
Lines 3024 3024
Branches 664 664
=======================================
Hits 2956 2956
Misses 64 64
Partials 4 4Continue to review full report at Codecov.
|
|
On a related note, what do y'all think about replacing the use of geckodriver with chromedriver? Chrome is more likely to be installed (most popular browser out there), and you can use the chromedriver npm package to download/run the binary. Would simplify the first few steps a bit |
|
I agree, Kevin, I think Chrome makes more sense. @klamping |
christian-bromann
added
the
PR: Docs 📝
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
## Proposed changes [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) - Adds requirement to run `npm init -y`, as the cli config auto-install has trouble otherwise - Adds some spacing to help with readability - Specifies that you need Firefox installed to use Geckodriver - Updates test runner section with a few more details ## Types of changes [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Docs ## Checklist [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) ## Further comments [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) ### Reviewers: @webdriverio/technical-committee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
npm init -y, as the cli config auto-install has trouble otherwiseTypes of changes
Checklist
Further comments
Reviewers: @webdriverio/technical-committee