webdriverio: fix appium getvalue #3606
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3606 +/- ##
=========================================
Coverage ? 98.79%
=========================================
Files ? 141
Lines ? 3075
Branches ? 672
=========================================
Hits ? 3038
Misses ? 35
Partials ? 2
Continue to review full report at Codecov.
|
| @@ -33,4 +33,18 @@ describe('getValue', () => { | |||
| await elem.getValue() | |||
| expect(request.mock.calls[2][0].uri.path).toBe('/wd/hub/session/foobar-123/element/some-elem-123/attribute/value') | |||
| }) | |||
|
|
|||
| it('should get value in mobile mode', async () => { | |||
There was a problem hiding this comment.
Does this test fail if you remove your fix for .getValue()?
There was a problem hiding this comment.
but how? it does the same assertion as in line 34, no?
There was a problem hiding this comment.
@christian-bromann assertion is the same, thats correct.
However capabilities are different
capabilities: {
browserName: 'foobar', // isW3C => true
mobileMode: true // isMobile => true
}
I'm creating instance in W3C and mobile mode: mobileMode: true
if (this.isMobile) { // true, thats why test is passing currently
if (this.isW3C) { // true, thats why test will fail if I remove the fix
We won't get to https://github.com/webdriverio/webdriverio/pull/3606/files/27f20ac559ca818b73cf5905012e3b099e59e6e4#diff-0aa25083832529e9bf1df741e54bd36aR34
There was a problem hiding this comment.
ahh ok no I see once expand the whole file. Let's do
if (this.isW3C && !this.isMobile) {then please. I am also wondering if this shouldn't be a bug reported in Appium.
There was a problem hiding this comment.
Ok, I'll update condition.
It should be either reported to Appium or if it is working as designed we need a link to prove that.
I'll take a look on Monday
| @@ -33,4 +33,18 @@ describe('getValue', () => { | |||
| await elem.getValue() | |||
| expect(request.mock.calls[2][0].uri.path).toBe('/wd/hub/session/foobar-123/element/some-elem-123/attribute/value') | |||
| }) | |||
|
|
|||
| it('should get value in mobile mode', async () => { | |||
There was a problem hiding this comment.
but how? it does the same assertion as in line 34, no?
|
Appium issue logged at appium/appium#12218 |
|
@christian-bromann thanks a lot for help! Updating PR right now according to requested changes |
|
@mgrybyk don't see the change applied, did you miss to push it? |
|
Let's wait until the highlight.js bug is fixed, I will rerun and merge then |
## Proposed changes fix webdriverio#3515 use non W3C method to getValue ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments most likely we have to submit ticket to Appium if there are no such iOS ``` session/{sessionId}/element/5000/property/value Method has not yet been implemented ``` Android ``` 404 - "unknown command: session/{sessionId}/element/0.12642389298468348-1/property/value" ``` ### Reviewers: @webdriverio/technical-committee
|
The bug for this PR was merged and released. I am not sure which issue your are referring to here. |
|
@christian-bromann - I was facing the error 'Method has not yet been implemented' for 'getProperty' command with WebDriverIO + Appium. Hence wanted to verify. Thank you for the update. |
Proposed changes
fix #3515
use non W3C method to getValue
Types of changes
Checklist
Further comments
most likely we have to submit ticket to Appium if there are no such
iOS
Android
Reviewers: @webdriverio/technical-committee