Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdio-sync: convert executeAsync to async/await #4620

Conversation

MatthewBurstein
Copy link
Contributor

Proposed changes

Convert executeAsync in @wdio/sync to async/await.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #4620 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4620      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files         195      195              
  Lines        5117     5109       -8     
  Branches     1099     1096       -3     
==========================================
- Hits         5083     5075       -8     
  Misses         31       31              
  Partials        3        3
Impacted Files Coverage Δ
packages/wdio-sync/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da00787...e04f332. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Oct 14, 2019
@christian-bromann christian-bromann merged commit b546ad5 into webdriverio:master Oct 14, 2019
@MatthewBurstein MatthewBurstein deleted the wdio-sync-executeAsync-tests branch October 14, 2019 12:20
@colinbendell
Copy link

colinbendell commented Oct 29, 2019

this is problematic for this.skip() calls which is a throw new Pending('sync skip'). This used to fall out of executeAsync() by being wrapped in a Promise.reject(). Now, it is caught and rethrown after prettying the e.stack. However, e.stack doesn't exist and so any use of this.skip() results in Cannot read property 'split' of undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants