Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autocompletion doc #4729

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Update autocompletion doc #4729

merged 2 commits into from
Nov 6, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Nov 4, 2019

Proposed changes

Update autocompletion doc https://webdriver.io/docs/autocompletion.html

  • removed obsolete/outdated steps (from my point of view)
  • added guide on how to enable autocompletion in VSCode with JavaScript

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@mgrybyk mgrybyk added the PR: Docs 📝 PRs that contain changes to the documentation label Nov 4, 2019
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #4729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4729   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         207      207           
  Lines        5306     5306           
  Branches     1145     1146    +1     
=======================================
  Hits         5274     5274           
  Misses         29       29           
  Partials        3        3
Impacted Files Coverage Δ
packages/webdriver/src/utils.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876f5bc...b9503be. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit ecfa90d into webdriverio:master Nov 6, 2019
@mgrybyk mgrybyk deleted the vscode-js-autocomplete branch November 23, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants