Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapCommand for async command execution #4858

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

christian-bromann
Copy link
Member

Proposed changes

The PR #4853 caused a regression with async test execution. This patch fixes it and adds smoke tests for async test runner execution.

closes #4849

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@mgrybyk
Copy link
Member

mgrybyk commented Dec 6, 2019

LGTM, let's wait for tests to pass

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #4858 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4858      +/-   ##
==========================================
+ Coverage   99.39%   99.39%   +<.01%     
==========================================
  Files         209      209              
  Lines        5470     5480      +10     
  Branches     1194     1196       +2     
==========================================
+ Hits         5437     5447      +10     
  Misses         30       30              
  Partials        3        3
Impacted Files Coverage Δ
packages/wdio-utils/src/shim.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb593e...12dfbb4. Read the comment docs.

Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 5272545 into master Dec 6, 2019
@christian-bromann christian-bromann deleted the cb-fix-async-runner branch December 6, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beforeCommand, afterCommand do not work when use async
2 participants