Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intercept service to wdio #4976

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Add intercept service to wdio #4976

merged 1 commit into from
Jan 24, 2020

Conversation

chmanie
Copy link
Contributor

@chmanie chmanie commented Jan 24, 2020

Proposed changes

Add the wdio-intercept-service to the cli and docs. It's already linked on the website (https://webdriver.io/docs/wdio-intercept-service.html)

Types of changes

  • Documentation update
  • CLI plugin addition

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (not applicable)
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/technical-committee

@jsf-clabot
Copy link

jsf-clabot commented Jan 24, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #4976 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4976   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         210      210           
  Lines        5504     5504           
  Branches     1178     1178           
=======================================
  Hits         5472     5472           
  Misses         29       29           
  Partials        3        3
Impacted Files Coverage Δ
packages/wdio-cli/src/constants.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f513428...a78663b. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor things

scripts/docs-generation/3rd-party/services.json Outdated Show resolved Hide resolved
packages/wdio-cli/src/constants.js Outdated Show resolved Hide resolved
packages/wdio-cli/src/constants.js Outdated Show resolved Hide resolved
@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jan 24, 2020
@christian-bromann christian-bromann added the backport-requested PRs with this label are considered to be applied to the last maintained version label Jan 24, 2020
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit cffb7d4 into webdriverio:master Jan 24, 2020
@christian-bromann christian-bromann added backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PRs with this label got backported to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants