Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework options TypeScript improvements #5214

Merged
merged 12 commits into from
Apr 9, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch adds proper typings for framework options.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann requested a review from a team April 6, 2020 08:25
@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Apr 6, 2020
@mgrybyk
Copy link
Member

mgrybyk commented Apr 7, 2020

Can't see require (or requireModule?) property in all the framework options. Am I missing something ?

docs/Frameworks.md Show resolved Hide resolved
docs/Frameworks.md Outdated Show resolved Hide resolved
@christian-bromann
Copy link
Member Author

@mgrybyk addressed your comments

Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 9e3f348 into master Apr 9, 2020
@christian-bromann christian-bromann deleted the cb-framework-opts-typings branch April 9, 2020 14:41
@christian-bromann christian-bromann added the backport-requested PRs with this label are considered to be applied to the last maintained version label Apr 9, 2020
@christian-bromann christian-bromann removed the backport-requested PRs with this label are considered to be applied to the last maintained version label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants