Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a11y protocol commands in puppeteer #6160

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

Based on #6158 this now adds these commands to the devtools package.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Nov 24, 2020
@christian-bromann christian-bromann requested a review from a team November 24, 2020 16:51
@christian-bromann christian-bromann merged commit c2cc620 into master Nov 24, 2020
@christian-bromann christian-bromann deleted the cb-a11y-devtools-commands branch November 24, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants