-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make use of ARIA Sematics role to identify element(webdriverio#6363) #6480
make use of ARIA Sematics role to identify element(webdriverio#6363) #6480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
resolved. kindly review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great progress, some more suggestions, also could you:
- update your branch to fix pipeline error
- add docs to our selectors section
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this 👍
Proposed changes
Ability to identify element based on ARIA Role (implicit & explicit)
issue#6363
browser.$('[role=button]').click();
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers