Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drag and drop #6600

Merged
merged 6 commits into from
Mar 22, 2021
Merged

Fix drag and drop #6600

merged 6 commits into from
Mar 22, 2021

Conversation

erwinheitzman
Copy link
Member

@erwinheitzman erwinheitzman commented Mar 18, 2021 •
edited
Loading

Proposed changes

Change the way the source and destination elements are used inside of the dragAndDrop command.

This should fix #6596
This should also fix the missing Jest types for the devDependencies

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman changed the title 6596 fix drag and drop Fix drag and drop Mar 18, 2021
christian-bromann
christian-bromann approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 22, 2021
@christian-bromann christian-bromann merged commit c642e80 into webdriverio:main Mar 22, 2021
@christian-bromann christian-bromann mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to to drag and drop an element
2 participants
@erwinheitzman @christian-bromann