Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly type config file if TypeScript is being used #6699

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch adds 3 changes to the config wizard:

  • it creates a .ts file if typescript is used
  • it types the config if typescript is used, e.g. file starts with
    export const config: WebdriverIO.Config = {
  • it adds expect-webdriverio to the types list in the confirmation note

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

fixes #5944

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Apr 13, 2021
@christian-bromann christian-bromann requested a review from a team April 13, 2021 09:00
@christian-bromann christian-bromann added the needs-review These Pull Requests require review from project members label Apr 13, 2021
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann christian-bromann merged commit f34a0af into main Apr 13, 2021
@christian-bromann christian-bromann deleted the cb-ts-config branch April 13, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review These Pull Requests require review from project members PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wdio cli install report/service - typed configuration support
2 participants