-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade lighthouse dependencies and fix performance tests #7019
Conversation
05f7b7a
to
058de96
Compare
d9512d3
to
e1231d4
Compare
This is blocked on a weird behavior in Chrome where it doesn't install a web manifest if the devtools app is not being opened. This requires some additional investigation. |
We should also add |
Already added via |
e1231d4
to
2a886c1
Compare
The problem with moving this forward is that there is a weird behavior with Chrome DevTools. Given you have the following test script: describe('webdriver.io page', () => {
it('should have the right title', () => {
browser.url('https://webdriver.io')
const result = browser.checkPWA()
console.log(result)
})
}) Lighthouse would detect the ServiceWorker to be registered and starting:
But then no other events happen until you open the DevTools app. I wonder which CDP commands trigger the commands to come in. This needs some further investigation. |
A couple thoughts -
|
2a886c1
to
48314ba
Compare
Any ETA for this issue? |
I am also curious of an update on this. I believe the bug I reported is also related to this. #7233. It's rendered dev-tools completely inoperable for us and we use dev tools in a number of ways from throttle to performance testing. When this issue shows and it's all the time now pages just don't render and ever test fails. |
We still have issues getting PWA testing to work due to a weird Chrome Devtools. Everyone can step in and investigate. I know that a lot of issues are connected to this. |
I'm having trouble getting a solid reproduction of the issue. If anybody would like to assist, a good first step would be to file a bug report within the Lighthouse package: https://github.com/GoogleChrome/lighthouse/issues and see what they say, and possibly cross-reference this issue. @tobeliketree perhaps you could help us with this? |
48314ba
to
e394cab
Compare
Raised an issue in the Lighthouse project: GoogleChrome/lighthouse#13127 |
@esaari mind resigning the CLA (we got a new one that is very similar to the old CLA from the JS Foundation). |
2c37fed
to
2bf7979
Compare
@esaari good news, I was able to fix the problem. Only need to adjust unit tests and clean up some things. |
🎉 |
Proposed changes
supersedes #6961
This patch bumps Lighthouse and Puppeteer versions and makes sure performance tests work again.
Types of changes
Checklist
Further comments
Thanks @esaari for your help on this!
Reviewers: @webdriverio/project-committers