Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate requestedCapabilities when attaching to running session #7155

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Propagate requestedCapabilities when attaching to running session #7155

merged 1 commit into from
Jul 19, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #7086

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 19, 2021
@christian-bromann christian-bromann requested a review from a team July 19, 2021 08:58
@christian-bromann christian-bromann mentioned this pull request Jul 19, 2021
Closed
@christian-bromann christian-bromann added the needs-review These Pull Requests require review from project members label Jul 19, 2021
@christian-bromann christian-bromann merged commit 150003b into main Jul 19, 2021
@christian-bromann christian-bromann deleted the cb-propagate-requestedCapabilities-when-attaching-to-session branch July 19, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrybyk mgrybyk mgrybyk approved these changes

Assignees
No one assigned
Labels
needs-review These Pull Requests require review from project members PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors occurring when using mock with selenoid (remote)
2 participants
@christian-bromann @mgrybyk