Updated xUnit test reporter #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check if test.err exists and changed test for whether a test has passed or failed. Tested both a test that should pass and a test that should fail. Both printed correctly.
| @@ -98,7 +98,7 @@ function XUnit(options) { | |||
| parentSuite.pending++; | |||
| test.id = ++id; | |||
| test.time = new Date() - tests[test.pid][0].end, | |||
There was a problem hiding this comment.
could you replace the , with an ; and remove the indentation below?
There was a problem hiding this comment.
@sixsixtrample I still see
test.time = new Date() - tests[test.pid][0].end,
but it should be
test.time = new Date() - tests[test.pid][0].end;
|
@sixsixtrample One comment on something that is not related to this but would be great if we can fix this as well. After that it is good to go |
removed indent and changed , to ;
| @@ -108,7 +108,7 @@ function XUnit(options) { | |||
| parentSuite.passes++; | |||
| test.id = ++id; | |||
| test.time = new Date() - tests[test.pid][0].end, | |||
| test.timestamp = tests[test.pid][0].end = new Date(); | |||
| test.timestamp = tests[test.pid][0].end = new Date(); | |||
| test.runnerData = runnerData[test.pid]; | |||
There was a problem hiding this comment.
please also change it here
Corrected , and ;
|
Ok, I believe they are all fixed. |
|
@sixsixtrample please have a look at the Files Change tab. Have you missed to push to Github? |
|
It says I have no uncommitted changes. And I pushed it to my fork. Is there something else I need to do? |
This was referenced Oct 7, 2015
christian-bromann
added a commit
that referenced
this pull request
Oct 8, 2015
Updated xUnit test reporter
|
Thanks! |
|
Published with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check if test.err exists and changed test for whether a test has
passed or failed. Tested both a test that should pass and a test that
should fail. Both printed correctly.