Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better transform unicode keys to Puppeteer key map #9544

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Better transform unicode keys to Puppeteer key map #9544

merged 1 commit into from
Jan 7, 2023

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #9401

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 7, 2023
@christian-bromann christian-bromann merged commit 4182cd2 into main Jan 7, 2023
@christian-bromann christian-bromann deleted the cb-fix-key-action-for-devtools branch January 7, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Key.Escape sends a unicode character to input field, instead of pressing Escape
1 participant
@christian-bromann