Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'module: ESNext' from config wizard's tsconfig.json template #9615

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Remove 'module: ESNext' from config wizard's tsconfig.json template #9615

merged 1 commit into from
Jan 17, 2023

Conversation

Jmelwood
Copy link
Contributor

Proposed changes

Was discovered that the generated tsconfig.json file from the configuration wizard includes a property that breaks proper TypeScript transpiling, so I removed it. (fixes #9539)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 16, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Jmcosel / name: Jeremy Elwood (f720188)

christian-bromann
christian-bromann approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the PR and congrats on your first contribution!

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 17, 2023
@christian-bromann christian-bromann merged commit 56d8648 into webdriverio:main Jan 17, 2023
christian-bromann added a commit that referenced this pull request Jan 20, 2023
@christian-bromann
Revert "Remove 'module: ESNext' from config wizard's tsconfig.json te…
0299def 
…mplate, fixes #9539 (#9615)"

This reverts commit 56d8648.
refs #9539
@vparlah vparlah mentioned this pull request Jan 20, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: ts page class is imported as .js and failing test when updating the import
2 participants
@Jmelwood @christian-bromann