Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade superagent #225

Closed
ksmyth opened this issue Mar 12, 2015 · 4 comments
Closed

Upgrade superagent #225

ksmyth opened this issue Mar 12, 2015 · 4 comments
Assignees
@lattmann
Labels
Blob Enhancement Minor
Milestone
v0.9.0

Comments

@ksmyth
Copy link
Contributor

ksmyth commented Mar 12, 2015

We have a custom superagent.js for the client to support binary downloads. A new release of superagent supports this:
ladjs/superagent#566

BlobClient.prototype.getObject may need to be changed for this API

(I would get the webgme-domain-tools karma tests that test the blob working before doing anything)
@ksmyth
Copy link
Contributor Author

ksmyth commented Mar 13, 2015

karma blob tests are working in master. Thanks @lattmann

@pmeijer pmeijer added the Blob label Mar 16, 2015
@lattmann lattmann added this to the v0.9.0 milestone Mar 17, 2015
@lattmann lattmann self-assigned this Mar 17, 2015
@lattmann lattmann mentioned this issue Mar 17, 2015
Closed
@lattmann
Copy link
Contributor

We do not use browserify. Superagent releases 1.0.0+ do not provide built client side libraries.

ladjs/superagent#587

lattmann pushed a commit that referenced this issue Mar 18, 2015
#225 upgrade superagent 0.18.2 -> 0.21.0
2be814f
@ksmyth
Copy link
Contributor Author

ksmyth commented Mar 18, 2015

superagent <1.0.0 doesn't have the fix from ladjs/superagent#566

We should include ksmyth/superagent@fd6ea13 in the browser superagent.js to support binary files

@ksmyth
Copy link
Contributor Author

ksmyth commented Mar 18, 2015

But the tests pass anyway. Maybe they fixed it in a different way?

@lattmann lattmann mentioned this issue Mar 18, 2015
Merged
lattmann pushed a commit that referenced this issue Apr 3, 2015
Upgrade to superagent 1.1.0 #225
db837aa
pmeijer pushed a commit that referenced this issue Apr 3, 2015
Pull request #292 closes #225 upgrade_to_superagent_1.1.0
5ab5a10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lattmann lattmann

Labels
Blob Enhancement Minor
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
3 participants
@ksmyth @lattmann @pmeijer