Rename feature #1477

kecso · 2017-07-27T18:41:36Z

The feature allows for renaming operations.
It introduces renaming functions on the Core API as well as enabling their use of the Meta editor.
It also introduces new server worker requests that can propagate these renamings.

Closes #1427 #1194 #1464 #1467 #1469

pmeijer

Finished with the first go on the core.js

pmeijer · 2017-07-27T18:56:06Z

src/client/js/client/rename.js

+
+    function gmeMetaRename(logger, state, storage, saveRoot) {
+
+        function renameConcept(nodePath, type, oldName, newName, callback) {


Gather all client ServerWorkerRequests in a file like this..

pmeijer · 2017-07-27T18:56:38Z

src/client/js/client/rename.js

+
+        function renameConcept(nodePath, type, oldName, newName, callback) {
+            var parameters = {
+                command: 'renameConcept',


/src/common/Constants.js SERVER_WORKER_REQUESTS

pmeijer · 2017-07-27T18:57:57Z

src/client/js/client/rename.js

+            });
+        }
+
+        function renameAttributeDefinition(nodePath, meta, oldName, newName, callback) {


Regarding naming - see if there is a pattern in the current ones...
client API function - SERVER_WORKER_REQUEST - and if it's there core.user API name

pmeijer · 2017-07-27T18:59:25Z

src/common/core/core.js

@@ -2357,6 +2357,21 @@ define([
        };

        /**
+         * Returns the list of the META defined pointer names of the node introduced by the nide.


pmeijer · 2017-07-27T19:00:12Z

src/common/core/core.js

@@ -2372,6 +2387,21 @@ define([
        };

        /**
+         * Returns the list of the META defined set names of the node introduced by its rules.


line 2360 consistent descriptions (also compare with getOwnValidChildrenTypes etc)

pmeijer · 2017-07-27T19:22:36Z

src/common/core/core.js

+        };
+
+        /**
+         * Renames the given attribute definition of the node. It also renames the default value of the definition!


It also renames the default value of the definition, but does not rename any values stored at instances.

pmeijer · 2017-07-27T19:26:21Z

src/common/core/core.js

+        /**
+         * Moves the given target definition over to a new pointer or set. As actual values in case of
+         * relation definitions vary quite a bit from the meta-targets, this function does not deals with
+         * the actual pointer/set target/members.


As actual values in case of relation definitions vary quite a bit from the meta-targets, this function does not deals with the actual pointer/set target/members.
->
Note this does not alter the actual pointer target or set members.

pmeijer · 2017-07-27T19:26:55Z

src/common/core/core.js

+        };
+
+        /**
+         * Moves the given target definition over to a new aspect. As actual values in case of


pmeijer · 2017-07-27T19:30:03Z

src/common/core/core.js

+        };
+
+        /**
+         * Returns if a node could be contained in the given container's aspect.


Returns if node is a valid aspect member of parent. Keep the same terminology

pmeijer · 2017-07-27T19:31:22Z

src/common/core/core.js

+        };
+
+        /**
+         * Returns the paths of Meta nodes that are possible targets of the given pointer/set introduced by the node.


...introduced by the node. -> ...where the node is the owner.

pmeijer · 2017-07-28T21:03:55Z

src/common/core/corerel.js

-            if (takenRelids) {
-                if (takenRelids[innerCore.getRelid(oldNode)]) {
-                    node = innerCore.createChild(parent, takenRelids, relidLength);
+            if (typeof newRelid === 'string') {


Shouldn't the same check as in createNode be applied here? (I know the newRelid isn't exposed at the top level core)

pmeijer · 2017-07-28T21:06:49Z

src/common/core/corerel.js

+
+            ASSERT(targetPath !== undefined);
+
+            if (pointerNames.indexOf(newName) !== -1) {


Shouldn't we throw here?

pmeijer · 2017-07-28T21:09:01Z

src/common/core/coretree.js

+            console.log(self.getPath(node), oldName, newName);
+            self.setProperty(node, newName, self.getProperty(node, oldName));
+            self.deleteProperty(node, oldName);
+        };


console and what happens if the property already exists? Shouldn't we throw?

pmeijer · 2017-07-28T21:19:26Z

src/common/core/metacore.js

@@ -558,14 +601,38 @@ define([

        this.setPointerMetaTarget = function (node, name, target, min, max) {
            self.addMember(metaPointerNode(node, name), CONSTANTS.SET_ITEMS, target);
-            min = min || -1;
+            min = min === 0 ? 0 : min || -1;


Add parenthesis to clearly show the order min = min === 0 ? 0 : (min || -1);

pmeijer · 2017-07-28T21:21:05Z

src/common/core/metacore.js

@@ -574,10 +641,10 @@ define([
        };

        this.setPointerMetaLimits = function (node, name, min, max) {
-            if (min) {
+            if (min || min === 0) {


typeof min === 'number' ?

pmeijer · 2017-07-28T21:32:36Z

src/common/core/mixincore.js

+
+            if (definedTarget) {
+                return {
+                    sourceNode: node,


pmeijer · 2017-07-28T21:34:51Z

src/common/core/mixincore.js

+        };
+
+        this.getChildDefinitionInfo = function (node, child) {
+            return getFirstMatchingRuleInfo(node, undefined, child, self.getValidChildrenPaths, {});


Shouldn't this be getOwnValidChildrenPaths

pmeijer · 2017-07-28T21:38:21Z

src/common/core/users/metarename.js

+     * actual definition was already changed among the meta definitions of the node.
+     * @param core
+     * @param node - any node in tree to be checked
+     * @param parameters


doc for the parameters

Can't the renames be batched?

pmeijer · 2017-07-28T21:40:28Z

src/common/core/users/metarename.js

+                    return;
+                })
+                .catch(function (err) {
+                    deferred.resolve(null);


Should all errors be swallowed here?

pmeijer · 2017-07-28T21:46:48Z

src/server/worker/workerrequests.js

@@ -1379,6 +1381,262 @@ function WorkerRequests(mainLogger, gmeConfig, webgmeUrl) {
            .nodeify(finish);
    }

+    function renameConcept(webgmeToken, parameters, callback) {


…functions

… functions

kecso added Client library Core Major Meta New feature UX/UI labels Jul 27, 2017

kecso added this to the v2.16.0 milestone Jul 27, 2017

kecso requested a review from pmeijer July 27, 2017 18:41

pmeijer reviewed Jul 27, 2017

View reviewed changes

kecso force-pushed the rename_meta branch from 3d1b021 to 3fdcd8f Compare July 28, 2017 04:29

pmeijer requested changes Jul 28, 2017

View reviewed changes

kecso added a commit that referenced this pull request Jul 29, 2017

#1477 - gaining test coverage

9e877be

kecso added 9 commits July 28, 2017 22:46

WIP - rebranching rename

4aa2dcb

WIP - first rename concept went through (pointer, end-to-end)

6a5d8bc

WIP - client functions were missing from previous commit

c0484b5

WIP - fine-tuning coreuser functions

4cd3fbb

WIP - implemented attribute change

b024c74

WIP - renaming definition of relations

a505f57

WIP - pointer renames have the 'proper' dialogs now.

ecace89

WIP - all renaming functionality is implemented

035f351

#1477 - gaining test coverage

0f32e59

kecso force-pushed the rename_meta branch from 9e877be to 0f32e59 Compare July 29, 2017 03:46

kecso added 8 commits July 30, 2017 14:20

#1477 - adressing review comments

9d6e10a

#1477 - fixes regarding review comments

d330d76

#1477 - typescript typings have been added according to new Core API …

987e213

…functions

#1477 - adding new core functions to client API as well

2f1dd56

#1477 - fixing review comments

ecd3540

#1477 - namespacing on the client API

6e628a2

#1477 - bumping version to beta3

f0c7c73

#1477 - fixes pointer creation dialog bugs

744bc8b

kecso added 8 commits July 31, 2017 13:02

#1477 - fixing errors on the client

355ce17

#1477 - fixing bugs found during manual test

d13e319

#1477 - fixing renam propagation issue

b524d5f

#1477 fixing upcoming issues with rename and other MetaEditor related…

e259a24

… functions

#1477 Fix mixin tests

d0ccd15

#1477 adding test coverage for workerrequest

877afe0

#1477 fix set related test

bb90345

#1477 fix so renameing to current won't be accepted

4f26080

kecso assigned pmeijer Jul 31, 2017

pmeijer approved these changes Jul 31, 2017

View reviewed changes

pmeijer merged commit fd8a488 into master Jul 31, 2017

This was referenced Jul 31, 2017

delAspectMetaTarget should remove aspect if empty #1469

Closed

getMixinPaths ordered #1467

Closed

Meta definition lookup functions #1464

Closed

Allow meta relations to be renamed #1194

Closed

kecso deleted the rename_meta branch August 2, 2017 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename feature #1477

Rename feature #1477

kecso commented Jul 27, 2017 •

edited by pmeijer

Loading

pmeijer left a comment

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 27, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017

pmeijer Jul 28, 2017


		function gmeMetaRename(logger, state, storage, saveRoot) {

		function renameConcept(nodePath, type, oldName, newName, callback) {


		ASSERT(targetPath !== undefined);

		if (pointerNames.indexOf(newName) !== -1) {

Rename feature #1477

Rename feature #1477

Conversation

kecso commented Jul 27, 2017 • edited by pmeijer Loading

pmeijer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kecso commented Jul 27, 2017 •

edited by pmeijer

Loading