Refactored crosscut functionality. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kecso
commented
Nov 18, 2015
kecso
commented
- connections now visualized like in Composition view
- set membership relation is visible
- relations can be filtered on every crosscut
- filter states are saved with the project
- default connection manager is set to CM2
- manual tests have been created and stored on google drive
- if a node is visualized as port and as a separate item as well the preference is at the item (so connections will end there)
- adding a node to the crosscut if it was already visualized as port is now possible (both become be visible)
- removing a node that is also visualized as port is now possible
- connections now visualized like in Composition view - set membership relation is visible - relations can be filtered on every crosscut - filter states are saved with the project - default connection manager is set to CM2 - manual tests have been created and stored on google drive - if a node is visualized as port and as a separate item as well the preference is at the item (so connections will end there) - adding a node to the crosscut if it was already visualized as port is now possible (both become be visible) - removing a node that is also visualized as port is now possible
| @@ -1808,6 +1868,7 @@ define(['js/logger', | |||
| this._GMEID2ComponentID[gmeID].push(uiComponent.id); | |||
| this._ComponentID2GMEID[uiComponent.id] = gmeID; | |||
|
|
|||
| this._delayedConnectionsAsItems = this._delayedConnectionsAsItems || {}; | |||
There was a problem hiding this comment.
Couldn't this property be defined in the constructor? Is it declared here too? Or is it set to null at some point?
There was a problem hiding this comment.
you are right, it should be in the constructor (or actually in the initialization of the tab...)
|
See #668 regarding using CM2.. |
|
I'll check the tests again with AR and remove the change of default CR if possible. Checked and it turned out, that we still have issues with the AR. I will create another issue for the AR. |
fixed review findings
|
Ok, is it ready to go? |
|
yepp, it should be good to go |
pmeijer
pushed a commit
that referenced
this pull request
Nov 20, 2015
Refactored crosscut functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.