AddOns can send notifications #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2015 10:00
ConstraintAddOn sends notification rather than updating the model.
lattmann
added a commit
that referenced
this pull request
Dec 10, 2015
AddOns can send notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NotificationWidget is improved:
Some improvements could be done in the notification bar regarding style and display time-stamp. However I still think the widget should be kept simple. When there is a plugin/addon notification the client dispatches a 'simple' notification for the notification-widget, but also a separate PLUGIN/ADD_ON_NOTIFICATION with more detailed data from the plugin/addOn. This data can also contain custom (domain/app specific) data. If there is a need and a good definition of how, then we can provide a generic plugin/addon widgets that consume that data.